[bugfix] tests: include ltx2_3_base in expected LTX2 preset set (#1427) - #1428
Conversation
…ai-lab#1427) `test_ltx2_presets_registered` hard-coded the previous three-preset set, but hao-ai-lab#1397 (LTX-2.3 transformer support) registered a fourth preset `ltx2_3_base` and made it the LTX2 default. The set-equality assertion trips on the extra item, failing on a clean `main` and red-lighting the shared unit-test CI job for every PR. Add `ltx2_3_base` to the expected set so it matches the presets actually registered for the `ltx2` family (ltx2_base, ltx2_3_base, ltx2_distilled, ltx2_two_stage). Fixes hao-ai-lab#1427
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the LTX2 preset registration test expectations to include a newly available preset name.
Changes:
- Extend the expected preset name set for the
ltx2family to includeltx2_3_base.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| presets = get_presets_for_family("ltx2") | ||
| names = {p.name for p in presets} | ||
| assert names == {"ltx2_base", "ltx2_distilled", "ltx2_two_stage"} | ||
| assert names == {"ltx2_base", "ltx2_3_base", "ltx2_distilled", "ltx2_two_stage"} |
There was a problem hiding this comment.
Code Review
This pull request updates the test suite in fastvideo/tests/api/test_presets.py to include the new ltx2_3_base preset in the expected set of registered presets for the ltx2 family. There are no review comments, and we have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟠 PR merge requirementsWaiting for
Waiting checks:
|
SolitaryThinker
left a comment
There was a problem hiding this comment.
Hi @Mister-Raggs — automated review from Gob, one of @SolitaryThinker's AI reviewers. Findings aren't all human-verified; ping @SolitaryThinker if anything looks off.
TL;DR
This PR updates the LTX2 preset registration test to include the already-registered ltx2_3_base preset. I verified the PR changes only fastvideo/tests/api/test_presets.py, the assertion is exact set equality, and the LTX2 preset source plus registry registration at the PR head contain exactly the four expected LTX2 preset names. Verdict: approve.
Verdict: approve
- S0 (blockers): 0
- S1 (must-fix): 0
- S2 (should-fix; surfaced if
persistentorimportant): 0 - S3 (discussion): 0
— Gob (@SolitaryThinker's AI reviewer). Full review (including S3 items) is archived locally.
hao-ai-lab#1428 fixed this exact assertion in fastvideo/tests/api/test_presets.py but missed the identical one in tests/local_tests/. Since local_tests are excluded from CI, test_ltx2_typed_surface_preflight has been failing since ltx2_3_base was registered in hao-ai-lab#1397.
hao-ai-lab#1428 fixed this exact assertion in fastvideo/tests/api/test_presets.py but missed the identical one in tests/local_tests/. Since local_tests are excluded from CI, test_ltx2_typed_surface_preflight has been failing since ltx2_3_base was registered in hao-ai-lab#1397.
Problem
fastvideo/tests/api/test_presets.py::TestLtx2Presets::test_ltx2_presets_registeredfails on a cleanmain:#1397 (LTX-2.3 transformer support) registered a fourth preset
ltx2_3_base(fastvideo/pipelines/basic/ltx2/presets.py) and made it the LTX2 default (fastvideo/registry.py), but the test still hard-codes the previous three-preset set. Because this lives in the shared unit-test job (run_unit_test→pytest ./fastvideo/tests/api/ ...), it red-lights CI for every open PR, not just the one that surfaced it.Fix
Add
ltx2_3_baseto the expected set so it matches the presets actually registered for theltx2family:Verified these are exactly the four
PresetSpecs withmodel_family="ltx2"registered infastvideo/pipelines/basic/ltx2/presets.py.Test evidence
Test-only change to a single assertion set; the
run_unit_testCI job (which coversfastvideo/tests/api/) is the validation surface and will exercise it on this PR.Fixes #1427