Skip to content

[bugfix] tests: include ltx2_3_base in expected LTX2 preset set (#1427) - #1428

Merged
SolitaryThinker merged 1 commit into
hao-ai-lab:mainfrom
Mister-Raggs:bugfix/ltx2-presets-test
Jun 4, 2026
Merged

[bugfix] tests: include ltx2_3_base in expected LTX2 preset set (#1427)#1428
SolitaryThinker merged 1 commit into
hao-ai-lab:mainfrom
Mister-Raggs:bugfix/ltx2-presets-test

Conversation

@Mister-Raggs

Copy link
Copy Markdown
Contributor

Problem

fastvideo/tests/api/test_presets.py::TestLtx2Presets::test_ltx2_presets_registered fails on a clean main:

>       assert names == {"ltx2_base", "ltx2_distilled", "ltx2_two_stage"}
E       AssertionError
E         Extra items in the left set:
E         'ltx2_3_base'

#1397 (LTX-2.3 transformer support) registered a fourth preset ltx2_3_base (fastvideo/pipelines/basic/ltx2/presets.py) and made it the LTX2 default (fastvideo/registry.py), but the test still hard-codes the previous three-preset set. Because this lives in the shared unit-test job (run_unit_testpytest ./fastvideo/tests/api/ ...), it red-lights CI for every open PR, not just the one that surfaced it.

Fix

Add ltx2_3_base to the expected set so it matches the presets actually registered for the ltx2 family:

assert names == {"ltx2_base", "ltx2_3_base", "ltx2_distilled", "ltx2_two_stage"}

Verified these are exactly the four PresetSpecs with model_family="ltx2" registered in fastvideo/pipelines/basic/ltx2/presets.py.

Test evidence

Test-only change to a single assertion set; the run_unit_test CI job (which covers fastvideo/tests/api/) is the validation surface and will exercise it on this PR.

Fixes #1427

…ai-lab#1427)

`test_ltx2_presets_registered` hard-coded the previous three-preset set,
but hao-ai-lab#1397 (LTX-2.3 transformer support) registered a fourth preset
`ltx2_3_base` and made it the LTX2 default. The set-equality assertion
trips on the extra item, failing on a clean `main` and red-lighting the
shared unit-test CI job for every PR.

Add `ltx2_3_base` to the expected set so it matches the presets actually
registered for the `ltx2` family (ltx2_base, ltx2_3_base, ltx2_distilled,
ltx2_two_stage).

Fixes hao-ai-lab#1427
Copilot AI review requested due to automatic review settings June 3, 2026 02:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the LTX2 preset registration test expectations to include a newly available preset name.

Changes:

  • Extend the expected preset name set for the ltx2 family to include ltx2_3_base.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

presets = get_presets_for_family("ltx2")
names = {p.name for p in presets}
assert names == {"ltx2_base", "ltx2_distilled", "ltx2_two_stage"}
assert names == {"ltx2_base", "ltx2_3_base", "ltx2_distilled", "ltx2_two_stage"}

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the test suite in fastvideo/tests/api/test_presets.py to include the new ltx2_3_base preset in the expected set of registered presets for the ltx2 family. There are no review comments, and we have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@mergify mergify Bot added type: bugfix Bug fix scope: infra CI, tests, Docker, build labels Jun 3, 2026
@mergify

mergify Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟠 PR merge requirements

Waiting for

  • check-success=full-suite-passed
  • check-success~=pre-commit
Waiting checks: full-suite-passed, pre-commit.
  • check-success=full-suite-passed
  • check-success~=pre-commit
  • #approved-reviews-by>=1
  • check-success=fastcheck-passed
  • title~=(?i)^\[(feat|feature|bugfix|fix|refactor|perf|ci|doc|docs|misc|chore|kernel|new.?model|skill|skills|infra)\]

@SolitaryThinker SolitaryThinker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Mister-Raggs — automated review from Gob, one of @SolitaryThinker's AI reviewers. Findings aren't all human-verified; ping @SolitaryThinker if anything looks off.

TL;DR

This PR updates the LTX2 preset registration test to include the already-registered ltx2_3_base preset. I verified the PR changes only fastvideo/tests/api/test_presets.py, the assertion is exact set equality, and the LTX2 preset source plus registry registration at the PR head contain exactly the four expected LTX2 preset names. Verdict: approve.

Verdict: approve

  • S0 (blockers): 0
  • S1 (must-fix): 0
  • S2 (should-fix; surfaced if persistent or important): 0
  • S3 (discussion): 0

— Gob (@SolitaryThinker's AI reviewer). Full review (including S3 items) is archived locally.

@SolitaryThinker
SolitaryThinker merged commit 3505d09 into hao-ai-lab:main Jun 4, 2026
9 of 10 checks passed
alanhuangyoo added a commit to alanhuangyoo/FastVideo that referenced this pull request Aug 26, 2026
hao-ai-lab#1428 fixed this exact assertion in fastvideo/tests/api/test_presets.py
but missed the identical one in tests/local_tests/. Since local_tests are
excluded from CI, test_ltx2_typed_surface_preflight has been failing
since ltx2_3_base was registered in hao-ai-lab#1397.
alanhuangyoo added a commit to alanhuangyoo/FastVideo that referenced this pull request Aug 26, 2026
hao-ai-lab#1428 fixed this exact assertion in fastvideo/tests/api/test_presets.py
but missed the identical one in tests/local_tests/. Since local_tests are
excluded from CI, test_ltx2_typed_surface_preflight has been failing
since ltx2_3_base was registered in hao-ai-lab#1397.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: infra CI, tests, Docker, build type: bugfix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_ltx2_presets_registered fails on main: ltx2_3_base registered but missing from expected preset set

3 participants