[ci] Repair fastcheck contract drift - #1728
Closed
Mister-Raggs wants to merge 1 commit into
Closed
Conversation
Contributor
Merge Protections🔴 1 of 1 protections blocking · waiting on 👀 reviews and 🤖 CI
🔴 PR merge requirementsWaiting for
This rule is failing.
|
Contributor
|
This PR has merge conflicts with the base branch. Please rebase: git fetch origin main
git rebase origin/main
# Resolve any conflicts, then:
git push --force-with-lease |
Collaborator
|
Closing as superseded by merged #1747. I verified that current main contains the schema classifications and explicit ATTN_QAT_INFER fail-closed behavior, replaces the Modal unit collection change with the active Slurm/macOS lane topology, and retains syntax-insensitive FA4 policy checks. Current-main validation passed: 27 capability/CI contract tests and 13 schema-parity tests. Rebasing this patch would duplicate or regress the current CI structure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fastcheck currently has several deterministic failures on
mainthat were exposed when #1727 changedpyproject.tomland therefore triggered every fastcheck lane:ATTN_QAT_INFERbackend fail loudly, while the duplicate API capability tests still expected silent fallback.mlxandplatformstest directories were neither collected nor explicitly allowlisted.Changes
ATTN_QAT_INFERhard-fail contract.PipelineConfigbase and extension fields.platformstests to the unit lane and explicitly document why the Apple/Metal-specificmlxsuite is not run on Linux CUDA Modal workers.Validation
pre-commit run --all-files: all hooks passed, including mypy.GPU memory impact
None. This changes test expectations, schema inventory metadata, and CI test collection only.
Context
Discovered while investigating unrelated fastcheck failures on #1727. The failing implementation and test files were byte-for-byte identical to upstream
mainbefore this repair.