[bugfix] registry: register magi_human presets - #1751
Open
alanhuangyoo wants to merge 1 commit into
Open
Conversation
Contributor
Merge Protections🔴 1 of 1 protections blocking · waiting on 👀 reviews and 🤖 CI
🔴 PR merge requirementsWaiting for
This rule is failing.
|
MagiHuman landed in hao-ai-lab#1299 with eight presets defined in fastvideo/pipelines/basic/magi_human/presets.py, but _register_presets() never imported them. get_presets_for_family("magi_human") returns an empty list and every get_preset() call for the family fails.
alanhuangyoo
force-pushed
the
fix/register-magi-human-presets
branch
from
August 26, 2026 08:12
0f55447 to
1c50ce2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fastvideo/pipelines/basic/magi_human/presets.pydefines eight presets, but_register_presets()infastvideo/registry.pynever imports them, so none of them reach the registry:Every other family in that function is wired up; magi_human is the only one whose
ALL_PRESETSis missing from both the import block andall_preset_groups. It looks like it was simply missed when the pipeline landed in #1299 —MAGI_HUMAN_PRESETShas never appeared inregistry.pyin the repo's history.After this change:
tests/local_tests/magi_human/test_magi_human_pipeline_smoke.py::test_magi_human_typed_surface_preflightalready asserts exactly this set and has been failing on main; it passes now. Preset counts for the other families are unchanged (ltx2 4, wan 15, zimage 1, flux2 3, minimax_h3 3).fastvideo/tests/api/gives 5 failed / 249 passed both with and without this patch — those failures are pre-existing (test_attn_qat_infer_capability_gate,test_schema_parity_inventory) and unrelated.Env: torch 2.12.0+cu130, H20, single node.