Skip to content

[bugfix] registry: register magi_human presets - #1751

Open
alanhuangyoo wants to merge 1 commit into
hao-ai-lab:mainfrom
alanhuangyoo:fix/register-magi-human-presets
Open

[bugfix] registry: register magi_human presets#1751
alanhuangyoo wants to merge 1 commit into
hao-ai-lab:mainfrom
alanhuangyoo:fix/register-magi-human-presets

Conversation

@alanhuangyoo

Copy link
Copy Markdown

fastvideo/pipelines/basic/magi_human/presets.py defines eight presets, but _register_presets() in fastvideo/registry.py never imports them, so none of them reach the registry:

>>> import fastvideo.registry
>>> from fastvideo.api.presets import get_preset, get_presets_for_family
>>> [p.name for p in get_presets_for_family("magi_human")]
[]
>>> get_preset("magi_human_base", "magi_human")
ConfigValidationError: pipeline.preset: unknown preset 'magi_human_base'
for model family 'magi_human'; registered: (none)

Every other family in that function is wired up; magi_human is the only one whose ALL_PRESETS is missing from both the import block and all_preset_groups. It looks like it was simply missed when the pipeline landed in #1299MAGI_HUMAN_PRESETS has never appeared in registry.py in the repo's history.

After this change:

>>> sorted(p.name for p in get_presets_for_family("magi_human"))
['magi_human_base', 'magi_human_base_ti2v', 'magi_human_distill',
 'magi_human_distill_ti2v', 'magi_human_sr_1080p', 'magi_human_sr_1080p_ti2v',
 'magi_human_sr_540p', 'magi_human_sr_540p_ti2v']

tests/local_tests/magi_human/test_magi_human_pipeline_smoke.py::test_magi_human_typed_surface_preflight already asserts exactly this set and has been failing on main; it passes now. Preset counts for the other families are unchanged (ltx2 4, wan 15, zimage 1, flux2 3, minimax_h3 3).

fastvideo/tests/api/ gives 5 failed / 249 passed both with and without this patch — those failures are pre-existing (test_attn_qat_infer_capability_gate, test_schema_parity_inventory) and unrelated.

Env: torch 2.12.0+cu130, H20, single node.

@mergify mergify Bot added the type: bugfix Bug fix label Aug 24, 2026
@mergify

mergify Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🔴 1 of 1 protections blocking · waiting on 👀 reviews and 🤖 CI

Protection Waiting on
🔴 PR merge requirements 👀 reviews and 🤖 CI

🔴 PR merge requirements

Waiting for

  • #approved-reviews-by>=1
  • check-success=full-suite-passed
This rule is failing.
  • #approved-reviews-by>=1
  • check-success=full-suite-passed
  • check-success=fastcheck-passed
  • check-success~=pre-commit
  • title~=(?i)^\[(feat|feature|bugfix|fix|refactor|perf|ci|doc|docs|misc|chore|kernel|new.?model|skill|skills|infra)\]

MagiHuman landed in hao-ai-lab#1299 with eight presets defined in
fastvideo/pipelines/basic/magi_human/presets.py, but _register_presets()
never imported them. get_presets_for_family("magi_human") returns an
empty list and every get_preset() call for the family fails.
@alanhuangyoo
alanhuangyoo force-pushed the fix/register-magi-human-presets branch from 0f55447 to 1c50ce2 Compare August 26, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant