[feat]: add MiniMax H3 Ref2VA and LoRA training support - #1757
[feat]: add MiniMax H3 Ref2VA and LoRA training support#1757Yanghao-Wang wants to merge 8 commits into
Conversation
Merge Protections🔴 1 of 1 protections blocking · waiting on 👀 reviews and 🤖 CI
🔴 PR merge requirementsWaiting for
This rule is failing.
|
|
@Yanghao-Wang, are you also planning to add support for FL2VA training? |
Thanks for asking. FL2VA training is not included in the scope of this PR, which focuses on Ref2VA and LoRA support for T2VA/Ref2VA. It can be added in a follow-up PR. ^-^ |
|
Got it, thanks! |
|
@SolitaryThinker Hi maintainers, fastcheck is blocked by 8 unit/contract failures in Attn-QAT, schema inventory, CI collection, and FA4 policy tests. I verified that the failing tests and corresponding source files are byte-identical to the base commit and are outside this PR’s changes. This PR appears to have triggered a broader test lane that exposed existing inconsistencies. Could you please confirm and advise whether fastcheck can be overridden for this PR or if I should wait for an upstream fix? The log is here. |
9a8d5b9 to
2495dfe
Compare
|
/merge |
|
/test full |
|
/test fastcheck |
|
/test full |
|
This PR has merge conflicts with the base branch. Please rebase: git fetch origin main
git rebase origin/main
# Resolve any conflicts, then:
git push --force-with-lease |
|
Hi @SolitaryThinker, I noticed that this PR now needs a rebase after the recent changes to main. Since the current head includes your follow-up commits and you previously updated the branch directly, I wanted to coordinate before making any changes. Are you planning to handle the rebase, or would you prefer me to take care of it? I’m happy to do so — I just want to avoid conflicting pushes. Thanks! |
|
Hi @SolitaryThinker, since the branch has remained unchanged and main has continued to move, I’m going to proceed with rebasing #1757 onto the current main to unblock it. I’ll preserve your follow-up commits and integrate the #1771 inference loader path with the training pre-FSDP path. I’ll use --force-with-lease to avoid overwriting any concurrent update. Please let me know if you are already working on the branch. |
Add Ref2VA training and enable LoRA training for both T2VA and Ref2VA.
2495dfe to
d4d4228
Compare
|
Quick update: I’ve completed the rebase onto the current main and pushed it with --force-with-lease. The PR is now mergeable, and fastcheck passed. The Trigger Merge Gate stopped at “Cancel previous Buildkite builds” before the merge tests were launched. It looks like the trigger may need a maintainer rerun when convenient. Thanks! |
|
Hi @SolitaryThinker, just following up on the rebased head. Fastcheck is green, and the PR is mergeable, but the merge gate has not been retriggered yet. Is there anything else you’d like me to address before it can proceed? Thanks! |
Purpose
Add MiniMax H3 Ref2VA training support and enable LoRA training for both T2VA and Ref2VA in the modular trainer.
Exact reviewed head:
2495dfea005bdb7d5ffe163049a233e50e47f425Changes
transformer/ortransformer_ref/component using canonical Diffusers safetensors naming and 5 GB sharding, while preserving the legacy filename for models that have not opted in.Validation
All results below are from the exact reviewed head unless noted otherwise.
.buildkite/scripts/unit_test.sh): 964 passed, 7 skipped.abc5e9bf71fd38f53cd471bc3acaa84bc5ecbfdc: 35 passed with no parity skips.The opt-in real-checkpoint gate passed on one 121 GiB NVIDIA GB10:
transformer_refsafetensors shards;Evidence boundary
The real-checkpoint gate validates strict loading and LoRA/FSDP ownership only. It does not run a forward pass, dataloader, optimizer step, full training job, export, reload, or inference. The CPU contracts cover those shapes and transformations, but this PR does not claim a completed full-checkpoint training/export/inference run.
Full H3 export deliberately gathers an additional roughly 62 GiB state on rank 0 while the live model exists. A 121 GiB unified-memory GB10 is therefore not a validated full-export target; use a larger-memory host for that gate.