feat: support AoE2 DE save version 67.x (v101.103.38580.0) - #141
Closed
sanduckhan wants to merge 1 commit into
Closed
sanduckhan wants to merge 1 commit into
sanduckhan wants to merge 1 commit into
Conversation
Save version 67.2 (game update v101.103.38580.0) introduced two new fields in the replay header format: 1. Per-player: a new 4-byte field at the end of each player record in parse_de(), after the existing save >= 64.3 field. 2. Post-player-loop: a new 8-byte field (Unix timestamp + 4-byte padding) after the save >= 66.3 block, before the lobby string. Without these reads, de_string() assertions fail on the second player's record (byte stream misalignment by 4 bytes per player), causing every replay from this game version to be rejected with "could not parse:". Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
Closing in favor of #139 which provides more comprehensive save version 67.x support (covers both fast and full parsers). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Save version 67.2 (game update v101.103.38580.0) introduced two new fields in the replay header format:
Per-player: a new 4-byte field at the end of each player record in parse_de(), after the existing save >= 64.3 field.
Post-player-loop: a new 8-byte field (Unix timestamp + 4-byte padding) after the save >= 66.3 block, before the lobby string.
Without these reads, de_string() assertions fail on the second player's record (byte stream misalignment by 4 bytes per player), causing every replay from this game version to be rejected with "could not parse:".