Conversation
Extract DE, HD, and Userpatch parsing logic into separate functions for clarity and easier debugging. This makes it much easier to understand what each version does and to identify version-specific parsing issues. - parse_scenario: dispatcher function that routes to version handler - _parse_scenario_de: DE-specific parsing with trigger handling - _parse_scenario_hd: HD-specific parsing - _parse_scenario_userpatch: Userpatch-specific parsing All existing tests pass. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Add type annotations to: - parse_scenario() dispatcher - _parse_scenario_de() DE-specific handler - _parse_scenario_hd() HD-specific handler - _parse_scenario_userpatch() Userpatch-specific handler All parameters and return types now properly annotated. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
nshankar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract DE, HD, and Userpatch parsing logic into separate functions for clarity and easier debugging. This also fixes the breaking change in 0a79c2c#diff-0d2aea043a17a46dc189c4f1b44e38171aa05d8a4d095bc3befc003daa8bbe4d that has been causing CI to fail
Changes
Test Results
✅ All 13 tests passing