BUG/MAJOR: bind: allow bind to parse multiple crt-list options

They are now parsed and serialized as CrtList field on the bind object
and delimited by ':'.

Author: mjuraga

config-parser/tests/bind_generated_test.go

@@ -270,6 +270,7 @@ type ACL struct{}
 //test:ok:bind :443 ssl tls-tickets
 //test:ok:bind :443 ssl no-strict-sni
 //test:ok:bind :443 ssl crt mycert1.pem crt mycert2.pem crt mycert3.pem
+//test:ok:bind :443 ssl crt-list list1.txt crt-list list2.txt
 //test:fail:bind :443 idle-ping
 //test:fail:bind :443 user
 //test:fail:bind :443 user mode 600

config-parser/tests/configs/haproxy_generated.cfg.go

@@ -352,7 +352,11 @@ func parseBindParams(bindOptions []params.BindOption) (models.BindParams, string
 			case "crt-ignore-err":
 				b.CrtIgnoreErr = v.Value
 			case "crt-list":
-				b.CrtList = v.Value
+				if b.CrtList == "" {
+					b.CrtList = v.Value
+				} else {
+					b.CrtList = fmt.Sprintf("%s:%s", b.CrtList, v.Value)
+				}
 			case "default-crt":
 				if b.DefaultCrtList == nil {
 					b.DefaultCrtList = []string{}
@@ -555,7 +559,9 @@ func serializeBindParams(b models.BindParams, name string, path string, opt *opt
 		options = append(options, &params.BindOptionValue{Name: "crt-ignore-err", Value: b.CrtIgnoreErr})
 	}
 	if b.CrtList != "" {
-		options = append(options, &params.BindOptionValue{Name: "crt-list", Value: b.CrtList})
+		for crtList := range strings.SplitSeq(b.CrtList, ":") {
+			options = append(options, &params.BindOptionValue{Name: "crt-list", Value: crtList})
+		}
 	}
 	if b.DefaultCrtList != nil {
 		for _, dc := range b.DefaultCrtList {

config-parser/tests/integration/frontend_data_test.go

@@ -0,0 +1,36 @@
+package configuration
+
+import (
+	"testing"
+
+	"github.com/haproxytech/client-native/v6/config-parser/params"
+	"github.com/haproxytech/client-native/v6/configuration/options"
+	"github.com/haproxytech/client-native/v6/models"
+
+	"github.com/stretchr/testify/require"
+)
+
+func TestParseBindParamsMultipleCrtList(t *testing.T) {
+	bindOptions := []params.BindOption{
+		&params.BindOptionValue{Name: "crt-list", Value: "list1.txt"},
+		&params.BindOptionValue{Name: "crt-list", Value: "list2.txt"},
+	}
+
+	b, _ := parseBindParams(bindOptions)
+
+	require.Equal(t, "list1.txt:list2.txt", b.CrtList)
+}
+
+func TestSerializeBindParamsMultipleCrtList(t *testing.T) {
+	b := models.BindParams{CrtList: "list1.txt:list2.txt"}
+
+	bindOptions := serializeBindParams(b, "", "", &options.ConfigurationOptions{})
+
+	var crtLists []string
+	for _, o := range bindOptions {
+		if v, ok := o.(*params.BindOptionValue); ok && v.Name == "crt-list" {
+			crtLists = append(crtLists, v.Value)
+		}
+	}
+	require.Equal(t, []string{"list1.txt", "list2.txt"}, crtLists)
+}

config-parser/tests/integration/frontend_test.go

@@ -294,6 +294,7 @@ definitions:
           ssl:
             value: true
       crt_list:
+        description: All of the certificate list files delimited by ':' as mentioned as a crt-list on the bind line.
         type: string
         x-dependency:
           ssl:

config-parser/types/types.go

@@ -80,6 +80,7 @@ bind_params:
           value: true
     crt_list:
       type: string
+      description: All of the certificate list files delimited by ':' as mentioned as a crt-list on the bind line.
       x-dependency:
         ssl:
           value: true