MINOR: global: add no-memory-trimming option

Add the no-memory-trimming global keyword to the config-parser and expose
it as performance_options.no_memory_trimming.

Author: mjuraga

config-parser/section-parsers.go

@@ -415,6 +415,7 @@ func (p *configParser) getGlobalParser() *Parsers { //nolint: maintidx
 	addParser(parser, &sequence, &simple.Enabled{Name: "busy-polling"})
 	addParser(parser, &sequence, &simple.String{Name: "max-spread-checks"})
 	addParser(parser, &sequence, &simple.String{Name: "close-spread-time"})
+	addParser(parser, &sequence, &simple.Enabled{Name: "no-memory-trimming"})
 	addParser(parser, &sequence, &simple.Enabled{Name: "noepoll"})
 	addParser(parser, &sequence, &simple.Enabled{Name: "nokqueue"})
 	addParser(parser, &sequence, &simple.Enabled{Name: "noevports"})

config-parser/tests/configs/haproxy.cfg.go

@@ -69,6 +69,7 @@ global
   ssl-default-bind-ciphers ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-AES256-GCM-SHA384:DHE-RSA-AES128-GCM-SHA256:DHE-DSS-AES128-GCM-SHA256:kEDH+AESGCM:ECDHE-RSA-AES128-SHA256:ECDHE-ECDSA-AES128-SHA256:ECDHE-RSA-AES128-SHA:ECDHE-ECDSA-AES128-SHA:ECDHE-RSA-AES256-SHA384:ECDHE-ECDSA-AES256-SHA384:ECDHE-RSA-AES256-SHA:ECDHE-ECDSA-AES256-SHA:DHE-RSA-AES128-SHA256:DHE-RSA-AES128-SHA:DHE-DSS-AES128-SHA256:DHE-RSA-AES256-SHA256:DHE-DSS-AES256-SHA:DHE-RSA-AES256-SHA:!aNULL:!eNULL:!EXPORT:!DES:!RC4:!3DES:!MD5:!PSK
   ssl-load-extra-del-ext
   log 127.0.0.1:514 local0 notice
+  no-memory-trimming
   expose-deprecated-directives
   force-cfg-parser-pause 1s
   warn-blocked-traffic-after 50ms

configuration/global.go

@@ -520,6 +520,15 @@ func parsePerformanceOptions(p parser.Parser) (*models.PerformanceOptions, error
 		options.Nosplice = nosplice
 	}
 
+	noMemoryTrimming, err := parseBoolOption(p, "no-memory-trimming")
+	if err != nil {
+		return nil, err
+	}
+	if noMemoryTrimming {
+		isEmpty = false
+		options.NoMemoryTrimming = noMemoryTrimming
+	}
+
 	nogetaddrinfo, err := parseBoolOption(p, "nogetaddrinfo")
 	if err != nil {
 		return nil, err
@@ -3110,6 +3119,10 @@ func serializePerformanceOptions(p parser.Parser, options *models.PerformanceOpt
 		return err
 	}
 
+	if err := serializeBoolOption(p, "no-memory-trimming", options.NoMemoryTrimming); err != nil {
+		return err
+	}
+
 	if err := serializeBoolOption(p, "nokqueue", options.Nokqueue); err != nil {
 		return err
 	}

models/performance_options.go

@@ -1391,6 +1391,9 @@ definitions:
       maxzlibmem:
         description: Maximum amount of RAM in megabytes per process usable by the zlib
         type: integer
+      no_memory_trimming:
+        description: Disables memory trimming (malloc_trim) on memory shortage or reload
+        type: boolean
       noepoll:
         description: Disable the use of the "epoll" event polling system on Linux
         type: boolean

models/performance_options_compare_test.go

@@ -1173,6 +1173,9 @@ performance_options:
     noevports:
       type: boolean
       description: Disable the use of the event ports event polling system on SunOS system derived from Solaris 10 and later
+    no_memory_trimming:
+      type: boolean
+      description: Disables memory trimming (malloc_trim) on memory shortage or reload
     nopoll:
       type: boolean
       description: Disable the use of the "poll" event polling system

models/performanceoptions_diff_generated.go

@@ -156,6 +156,7 @@ global
   nopoll
   nosplice
   nogetaddrinfo
+  no-memory-trimming
   noreuseport
   profiling.tasks on
   spread-checks 10