BUG/MEDIUM: healtcheck: fix naming to be standard

Author: mjuraga

configuration/structured_healthcheck.go

@@ -60,7 +60,7 @@ func (c *client) GetStructuredHealthcheck(name string, transactionID string) (in
 	if err != nil {
 		return v, nil, err
 	}
-	healthCheck.HTTPCheckRuleList = hchecks
+	healthCheck.HTTPCheckList = hchecks
 
 	// parse the TCP check rules for this health check
 	tchecks, err := ParseTCPChecks(HealthcheckParentName, name, p)
@@ -97,7 +97,7 @@ func (c *client) GetStructuredHealthchecks(transactionID string) (int64, models.
 			if err != nil {
 				return v, nil, err
 			}
-			healthCheck.HTTPCheckRuleList = hchecks
+			healthCheck.HTTPCheckList = hchecks
 
 			// parse the TCP check rules for this health check
 			tchecks, err := ParseTCPChecks(HealthcheckParentName, name, p)
@@ -190,7 +190,7 @@ func serializeHealthcheckSection(a StructuredToParserArgs, h *models.HealthCheck
 		return err
 	}
 
-	for i, httpCheck := range h.HTTPCheckRuleList {
+	for i, httpCheck := range h.HTTPCheckList {
 		var s types.Action
 		s, err = SerializeHTTPCheck(*httpCheck)
 		if err != nil {

models/health_check.go

@@ -4387,7 +4387,7 @@ definitions:
       - properties:
           http_check_list:
             $ref: '#/definitions/http_checks'
-            x-go-name: HTTPCheckRuleList
+            x-go-name: HTTPCheckList
           tcp_check_list:
             $ref: '#/definitions/tcp_checks'
             x-go-name: TCPCheckRuleList

models/healthcheck_diff_generated.go

@@ -12,7 +12,7 @@ healthcheck:
           x-go-name: TCPCheckRuleList
         http_check_list:
           $ref: "#/definitions/http_checks"
-          x-go-name: HTTPCheckRuleList
+          x-go-name: HTTPCheckList
 healthcheck_base:
   type: object
   description: HealthCheck with all it's children resources