BUILD/MINOR: update tolling used to check code

Format code across the repository to resolve line length warnings, primarily by wrapping long logger.LogAttrs statements and function calls to span multiple lines.

Author: oktalz

.gitignore

@@ -16,3 +16,4 @@ ci/k0s/k0s-data/
 test/conformance/conformance-report.yaml
 conformance-junit.xml
 conformance-junit.html
+gitlab-mr-checker

api/gate/v3/register.go

@@ -43,7 +43,8 @@ func Resource(resource string) schema.GroupResource {
 
 // Adds the list of known types to api.Scheme.
 func addKnownTypes(scheme *runtime.Scheme) error {
-	scheme.AddKnownTypes(SchemeGroupVersion,
+	scheme.AddKnownTypes(
+		SchemeGroupVersion,
 		&HugGate{},
 		&HugGateList{},
 		&HugConf{},

cmd/gitlab-mr-checker/main.go

@@ -61,6 +61,7 @@ const LABEL_COLOR = "#8fbc8f"
 // reruns won't re-add labels the user has since removed manually.
 const autoBackportMarker = `<!-- MR AUTO BACKPORT -->`
 
+//revive:disable-next-line:function-length
 func main() {
 	fmt.Print(hello) //nolint:forbidigo
 

hug/haproxy/api/acls.go

@@ -57,7 +57,8 @@ func (c *clientNative) ACLReplaceAll(parentType parser.Section, name string, rul
 	for index, rule := range rules {
 		err := c.ACLsCreate(index, parentType, name, rule)
 		if err != nil {
-			c.logger.LogAttrs(context.Background(), slog.LevelError, "failed to create ACL rule",
+			c.logger.LogAttrs(
+				context.Background(), slog.LevelError, "failed to create ACL rule",
 				logging.LogAttrError(err),
 				slog.Int("rule index", index),
 				slog.String("frontend", name),
@@ -79,7 +80,8 @@ func (c *clientNative) ACLsReplaceAll(parentType parser.Section, name string, ru
 	for index, rule := range rules {
 		err := c.ACLsCreate(index, parentType, name, rule)
 		if err != nil {
-			c.logger.LogAttrs(context.Background(), slog.LevelError, "failed to create ACL rule",
+			c.logger.LogAttrs(
+				context.Background(), slog.LevelError, "failed to create ACL rule",
 				logging.LogAttrError(err),
 				slog.Int("rule index", index),
 				slog.String("frontend", name),

hug/haproxy/api/backend.go

@@ -35,7 +35,8 @@ func (c *clientNative) BackendCreate(backend models.Backend) error {
 	if errCreate != nil {
 		// ... maybe it's already existing, so just edit it.
 		if err := configuration.EditStructuredBackend(backend.Name, &backend, c.activeTransaction, 0); err != nil {
-			c.logger.LogAttrs(context.Background(), slog.LevelError, "failed to edit backend",
+			c.logger.LogAttrs(
+				context.Background(), slog.LevelError, "failed to edit backend",
 				logging.LogAttrError(err),
 				slog.String("backend", backend.Name),
 			)
@@ -92,14 +93,16 @@ func (c *clientNative) BackendEdit(backend models.Backend) error {
 	// Check if only Servers were updated
 	onlyServersUpdated := false
 	if cmp.Equal(previousBackend, backend, cmpopts.IgnoreFields(models.Backend{}, "Servers")) {
-		c.logger.LogAttrs(context.Background(), slog.LevelInfo, "Only Servers are updated",
+		c.logger.LogAttrs(
+			context.Background(), slog.LevelInfo, "Only Servers are updated",
 			slog.String("backend", backend.Name),
 		)
 		onlyServersUpdated = true
 	}
 
 	if err := configuration.EditStructuredBackend(backend.Name, &backend, c.activeTransaction, 0); err != nil {
-		c.logger.LogAttrs(context.Background(), slog.LevelError, "Failed to edit backend",
+		c.logger.LogAttrs(
+			context.Background(), slog.LevelError, "Failed to edit backend",
 			logging.LogAttrError(err),
 			slog.String("backend", backend.Name),
 		)
@@ -115,7 +118,8 @@ func (c *clientNative) BackendEdit(backend models.Backend) error {
 				// If failed, we need to reload
 				reload.Instance().SetReload("[onlyServersUpdated] [runtime] servers state update failure - backend %s", backend.Name)
 			} else {
-				c.logger.LogAttrs(context.Background(), slog.LevelDebug, "[onlyServersUpdated] [runtime] success",
+				c.logger.LogAttrs(
+					context.Background(), slog.LevelDebug, "[onlyServersUpdated] [runtime] success",
 					slog.String("backend", backend.Name),
 				)
 			}

hug/haproxy/api/backend_switching_rules.go

@@ -56,7 +56,8 @@ func (c *clientNative) UseBackendReplaceAll(name string, rules models.BackendSwi
 	for index, rule := range rules {
 		err := c.UseBackendCreate(index, name, rule)
 		if err != nil {
-			c.logger.LogAttrs(context.Background(), slog.LevelError, "failed to create use-backend rule",
+			c.logger.LogAttrs(
+				context.Background(), slog.LevelError, "failed to create use-backend rule",
 				logging.LogAttrError(err),
 				slog.Int("rule index", index),
 				slog.String("frontend", name),

hug/haproxy/api/bind.go

@@ -81,7 +81,8 @@ func (c *clientNative) BindReplaceAll(parentType parser.Section, name string, bi
 
 	for _, bind := range binds {
 		if err := c.BindCreate(parentType, name, bind); err != nil {
-			c.logger.LogAttrs(context.Background(), slog.LevelError, "failed to create bind",
+			c.logger.LogAttrs(
+				context.Background(), slog.LevelError, "failed to create bind",
 				logging.LogAttrError(err),
 				slog.String("bind", bind.Name),
 				slog.String("parent", name),

hug/haproxy/api/client.go

@@ -108,7 +108,8 @@ func New(logger *slog.Logger, transactionDir, configFile, programPath, runtimeSo
 		return nil, err
 	}
 
-	confClient, err := configuration.New(context.Background(),
+	confClient, err := configuration.New(
+		context.Background(),
 		cfgoptions.ConfigurationFile(configFile),
 		cfgoptions.HAProxyBin(programPath),
 		cfgoptions.UseModelsValidation,
@@ -220,7 +221,8 @@ func (c *clientNative) APIFinalCommitTransaction() error {
 
 	if c.configurationHashAtTransactionStart == hash {
 		if errDel := config.DeleteTransaction(c.activeTransaction); errDel != nil {
-			c.logger.LogAttrs(context.Background(), slog.LevelError,
+			c.logger.LogAttrs(
+				context.Background(), slog.LevelError,
 				"failed to delete transaction",
 				logging.LogAttrError(errDel),
 				slog.String("transactionID", c.activeTransaction),
@@ -232,7 +234,8 @@ func (c *clientNative) APIFinalCommitTransaction() error {
 
 	_, err = config.CommitTransaction(c.activeTransaction)
 	if err != nil {
-		c.logger.LogAttrs(context.Background(), slog.LevelError,
+		c.logger.LogAttrs(
+			context.Background(), slog.LevelError,
 			"failed to commit transaction",
 			logging.LogAttrError(err),
 			slog.String("transactionID", c.activeTransaction),

hug/haproxy/api/frontend.go

@@ -31,7 +31,8 @@ func (c *clientNative) FrontendCreate(frontend models.Frontend) error {
 	if errCreate != nil {
 		// ... maybe it's already existing, so just edit it.
 		if err := configuration.EditStructuredFrontend(frontend.Name, &frontend, c.activeTransaction, 0); err != nil {
-			c.logger.LogAttrs(context.Background(), slog.LevelError, "failed to edit frontend",
+			c.logger.LogAttrs(
+				context.Background(), slog.LevelError, "failed to edit frontend",
 				logging.LogAttrError(err),
 				slog.String("frontend", frontend.Name),
 			)
@@ -82,7 +83,8 @@ func (c *clientNative) FrontendEdit(frontend models.Frontend) error {
 		return err
 	}
 	if err := configuration.EditFrontend(frontend.Name, &frontend, c.activeTransaction, 0); err != nil {
-		c.logger.LogAttrs(context.Background(), slog.LevelError, "failed to edit frontend",
+		c.logger.LogAttrs(
+			context.Background(), slog.LevelError, "failed to edit frontend",
 			logging.LogAttrError(err),
 			slog.String("frontend", frontend.Name),
 		)

hug/haproxy/api/http-requests.go

@@ -57,7 +57,8 @@ func (c *clientNative) HTTPRequestReplaceAll(parentType parser.Section, name str
 	for index, rule := range rules {
 		err := c.HTTPRequestCreate(index, parentType, name, rule)
 		if err != nil {
-			c.logger.LogAttrs(context.Background(), slog.LevelError, "failed to create http-request rule",
+			c.logger.LogAttrs(
+				context.Background(), slog.LevelError, "failed to create http-request rule",
 				logging.LogAttrError(err),
 				slog.Int("rule index", index),
 				slog.String("frontend", name),