MINOR: haproxy: add service name override (#382)

* haproxy: add service name override

Signed-off-by: Konstantin Kelemen <konstantin@kel.mn>

* update httproute and ingress templates

Signed-off-by: Konstantin Kelemen <konstantin@kel.mn>

* MINOR: haproxy: centralise and quote the service name override

The service.name fallback was spelled out at all four references to the
Service (service.yaml, both ingress.yaml API branches, httproute.yaml),
so any template added later would silently regress to the fullname and
the two ingress branches had to be kept in sync by hand. Move it into a
haproxy.serviceName helper alongside the existing name helpers.

Quote the rendered name as well. Kubernetes parses manifests with YAML
1.1 semantics, so a valid DNS-1035 Service name such as "on", "off",
"yes" or "no" was coerced to a boolean and the object rejected with
"cannot unmarshal !!bool into string".

Signed-off-by: Dinko Korunic <dkorunic@haproxy.com>

* MINOR: haproxy: document the service.name default and rename caveat

The comment claimed the default was .Release.Name, but the Service is
named after haproxy.fullname, ie. "<release>-haproxy". It also used a
trailing comment where the rest of the block documents keys above them.

Add the caveat that renaming the Service of an existing release replaces
it rather than updating it in place: the ClusterIP changes and, with
type LoadBalancer, the cloud provider provisions a new load balancer
with a new external address.

Signed-off-by: Dinko Korunic <dkorunic@haproxy.com>

* MINOR: haproxy: add CI values file for the service name override

Nothing under haproxy/ci/ set service.name, so the consistency between
the Service and the Ingress backend it is referenced from was never
asserted by local-test.sh or the integration-test.sh ci scenario.

httpRoute is left disabled: install_charts.sh only brings up the Gateway
API CRDs for the charts that need cloud-provider-kind, and httproute.yaml
has no .Capabilities.APIVersions gate, so enabling it here would break
ct install. That path is still rendered offline by local-test.sh.

Signed-off-by: Dinko Korunic <dkorunic@haproxy.com>

---------

Signed-off-by: Konstantin Kelemen <konstantin@kel.mn>
Signed-off-by: Dinko Korunic <dkorunic@haproxy.com>
Co-authored-by: Dinko Korunic <dkorunic@haproxy.com>

Author: konstantin-kelemen

haproxy/ci/deployment-servicename-values.yaml

@@ -0,0 +1,5 @@
+kind: Deployment
+service:
+  name: haproxy-custom-svc
+ingress:
+  enabled: true

haproxy/templates/_helpers.tpl

@@ -88,6 +88,13 @@ Create the name of the service account to use
 {{- end }}
 {{- end }}
 
+{{/*
+Create the name of the service to use
+*/}}
+{{- define "haproxy.serviceName" -}}
+{{- default (include "haproxy.fullname" .) .Values.service.name }}
+{{- end }}
+
 {{/*
 Create includes name
 */}}

haproxy/templates/httproute.yaml

@@ -34,7 +34,7 @@ spec:
       {{- toYaml . | nindent 8 }}
     {{- end }}
       backendRefs:
-        - name: {{ $fullName }}
+        - name: {{ include "haproxy.serviceName" $ | quote }}
           port: {{ $svcPort }}
     {{- end }}
 {{- end }}

haproxy/templates/ingress.yaml

@@ -43,11 +43,11 @@ spec:
             backend:
               {{- if semverCompare ">=1.19-0" $.Capabilities.KubeVersion.GitVersion }}
               service:
-                name: {{ $fullName }}
+                name: {{ include "haproxy.serviceName" $ | quote }}
                 port:
                   number: {{ $svcPort }}
               {{- else }}
-              serviceName: {{ $fullName }}
+              serviceName: {{ include "haproxy.serviceName" $ | quote }}
               servicePort: {{ $svcPort }}
               {{- end }}
           {{- end }}

haproxy/templates/service.yaml

@@ -17,7 +17,7 @@ limitations under the License.
 apiVersion: v1
 kind: Service
 metadata:
-  name: {{ include "haproxy.fullname" . }}
+  name: {{ include "haproxy.serviceName" . | quote }}
   namespace: {{ include "haproxy.namespace" . }}
   labels:
     {{- include "haproxy.labels" . | nindent 4 }}

haproxy/values.yaml

@@ -492,6 +492,13 @@ PodDisruptionBudget:
 ## Service configuration
 ## ref: https://kubernetes.io/docs/concepts/services-networking/service/
 service:
+  ## Service name override
+  ## Defaults to the chart fullname, ie. "<release>-haproxy"
+  ## NOTE: renaming the Service of an existing release replaces it, so the
+  ## ClusterIP changes and, with type LoadBalancer, the cloud provider tears down
+  ## the old load balancer and provisions a new one with a new external address
+  name: ""
+
   type: ClusterIP   # can be 'ClusterIP', 'NodePort', 'LoadBalancer'
 
   ## Service ClusterIP