Conversation
golang.org/x/text v0.38.0 carries GO-2026-5970, an infinite loop on invalid input in the normalisation code, fixed in v0.39.0. govulncheck reaches it from two places, both outside the controller: the e2e client in deploy/tests/e2e/client.go, through http.Client.Do, and the documentation generator in cmd/docs/annotations.go, through the cases package. The controller itself does not call it, so the exposure is the test suite and the doc target rather than a running instance.
Nothing in the pipeline looks at the known vulnerabilities of the dependencies. govulncheck reports only the ones the code actually reaches, so it stays quiet on a vulnerability that sits in a module without being called, and it needs no configuration. The job runs on a pull request and on a push to master. It passes on the tree as of the previous commit, which raised golang.org/x/text to the version that carries the fix for GO-2026-5970. The action is pinned by digest rather than by tag, with the version in a comment. This is the form a bot keeps current, see the Renovate issue.
PixiBixi
force-pushed
the
build/govulncheck
branch
from
August 26, 2026 22:28
a8e3294 to
0867e8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
govulncheckjob, together with the dependency bump that makes it pass, so thejob arrives green and has a demonstrated reason to exist.
The finding
govulncheck ./...on master today:Both call sites are outside the controller: the e2e client and the documentation
generator. A running instance does not reach it, so this is not urgent, but it is exactly
the class of thing that is easier to keep at zero than to clean up later.
The first commit raises
golang.org/x/textto v0.39.0. After it:The 1 imported and 3 required vulnerabilities that the scan also mentions are not called
by the code, and govulncheck does not fail on those.
The job
19 lines, no configuration.
golang/govulncheck-actionreads the Go version fromgo.mod, and govulncheck reports only what the code actually reaches, so it stays quieton a vulnerability sitting unused in a module. That is what keeps it from becoming the
job everyone learns to ignore.
The action is pinned by digest with the version in a comment, rather than by tag. That is
the form a bot keeps current, which is the subject of #842.
Checks
go build ./..., the unit suite, andmake check-commitare clean with the bump applied.Related: #843 restricts the token permissions of the workflows.