Commit 8e1add3
committed
fix(llm): use non-greedy quantifier when stripping bracket and paren groups from script
format_response used re.sub(r"\[.*\]", ...) and re.sub(r"\(.*\)", ...).
The greedy .* matches from the first opener to the *last* closer on the
same line, silently deleting all intervening content.
Examples of silent data loss:
"[Intro] Great content [end]" → "."
"Save (at least) 10% (monthly)." → "Save ."
Replacing .* with .*? makes each substitution non-greedy so that every
bracket/paren group is removed individually, leaving surrounding words
intact.
Add a unit test that feeds a two-group input through generate_script and
asserts the text between groups is preserved.1 parent 465b8b3 commit 8e1add3
2 files changed
Lines changed: 40 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
536 | 536 | | |
537 | 537 | | |
538 | 538 | | |
539 | | - | |
540 | | - | |
541 | | - | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
542 | 544 | | |
543 | 545 | | |
544 | 546 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
155 | 155 | | |
156 | 156 | | |
157 | 157 | | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
158 | 193 | | |
159 | 194 | | |
160 | 195 | | |
| |||
0 commit comments