fix(api): quote filename in Content-Disposition download header - #1265
Merged
harry0703 merged 1 commit intoAug 26, 2026
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d47ab6056
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ame quoting The previous manual header built an unquoted filename token, and a simple-quoted fix would still produce malformed output for filenames containing double-quotes or backslashes (e.g. name="draft".mp4 → filename="name="draft".mp4"). Starlette's FileResponse(filename=...) already handles all quoted-string escaping per RFC 6266, so drop the hand-rolled header entirely and let the framework build it correctly. Also simplify file_path.stem + extension back to file_path.name since stem+suffix was a round-trip to the same value. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Mihir7027
force-pushed
the
fix/content-disposition-filename-quoting
branch
from
August 25, 2026 18:11
7d47ab6 to
85d321d
Compare
Owner
|
Thanks for the fix! I’ve merged it and added regression coverage for ASCII, spaced, non-ASCII, and header-sensitive filenames on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Content-Dispositionheader in the video download endpoint was building an unquotedfilenametoken.filenameparameter must be a quoted-string. An unquoted filename containing spaces or special characters produces a malformed header, which causes browsers to truncate or reject the suggested filename.Change