fix(webui): avoid Windows-reserved download names - #1288
Merged
harry0703 merged 2 commits intoAug 31, 2026
Conversation
harry0703
added a commit
that referenced
this pull request
Aug 31, 2026
Handle superscript device names and whitespace variants, and expand download filename regression coverage. Follow-up-to: #1288
Owner
|
Thank you for the contribution! This has been merged. We also added a small follow-up to cover the remaining Windows reserved-name variants and expanded the regression tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CON,AUX, andLPT1so downloads remain cross-platform safeTesting
uv run --no-sync python -X utf8 -m pytest -q test/services/test_webui_task_history.py test/services/test_webui_task.py(25 passed)uv run --no-sync ruff check webui/Main.py test/services/test_webui_task_history.py test/services/test_webui_task.pyuv run --no-sync python -m compileall webui test/services/test_webui_task_history.py