feat: migrate roles ACL components to HDS - #23846
Open
suresh-hashicorp wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the ACL Roles UI components to the HashiCorp Design System (HDS).
Changes
app/components/consul/role/form/index.hbs— updated role form to use HDS componentsapp/components/consul/role/form/index.scss— new scoped styles for the role formapp/components/consul/role/fieldsets/— new fieldsets component (index.hbs, README.mdx)app/components/token-list/index.hbs— updated token list templateapp/components/token-list/pageobject.js— updated page object for token listapp/controllers/dc/acls/roles/edit.js— updated edit controllerapp/styles/components.scss— component style updatesapp/styles/routes/dc/acls/index.scss— ACL route style updatesapp/templates/dc/acls/roles/edit.hbs— updated edit templatetests/integration/components/consul/role/form-test.js— updated integration teststests/pages/dc/acls/roles/edit.js— updated page object for roles editRelated
Part of the broader HDS migration work, targeting the roles section of ACLs.