Skip to content

fix(engine): wire up is_dag_orchestrator col on the task events #5199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrkaye97 merged 1 commit into from
Oct 14, 2026
Merged

fix(engine): wire up is_dag_orchestrator col on the task events #5199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions cmd/hatchet-migrate/migrate/migrations/20261013191212_v1_0_172.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
-- +goose Up
-- +goose StatementBegin
ALTER TABLE v1_task_events_olap ADD COLUMN is_dag_orchestrator BOOLEAN NOT NULL DEFAULT FALSE;
-- +goose StatementEnd

-- +goose Down
-- +goose StatementBegin
ALTER TABLE v1_task_events_olap DROP COLUMN is_dag_orchestrator;
-- +goose StatementEnd
1 change: 1 addition & 0 deletions internal/services/controllers/olap/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1108,6 +1108,7 @@ func (tc *OLAPControllerImpl) handleCreateMonitoringEvent(ctx context.Context, t
WorkerID: workerId,
AdditionalEventMessage: sqlchelpers.TextFromStr(eventMessages[i]),
ExternalID: eventExternalIds[i],
IsDagOrchestrator: taskIdsToMetas[taskId].IsDagOrchestrator,
}

switch eventTypes[i] {
Expand Down
3 changes: 2 additions & 1 deletion pkg/repository/sqlcv1/copyfrom.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pkg/repository/sqlcv1/models.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions pkg/repository/sqlcv1/olap.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,8 @@ INSERT INTO v1_task_events_olap (
additional__event_data,
additional__event_message,
external_id,
durable_invocation_count
durable_invocation_count,
is_dag_orchestrator
) VALUES (
$1,
$2,
Expand All @@ -257,7 +258,8 @@ INSERT INTO v1_task_events_olap (
$12,
$13,
$14,
$15
$15,
$16
);

-- name: ReadTaskByExternalID :one
Expand Down
13 changes: 7 additions & 6 deletions pkg/repository/sqlcv1/olap.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions sql/schema/v1-olap.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,7 @@ CREATE TABLE v1_task_events_olap (
additional__event_data TEXT,
additional__event_message TEXT,
durable_invocation_count INT NOT NULL DEFAULT 0,
is_dag_orchestrator BOOLEAN NOT NULL DEFAULT FALSE,

PRIMARY KEY (task_id, task_inserted_at, id)
) PARTITION BY RANGE (task_inserted_at);
Expand Down
Loading