Repository navigation
fix(engine): don't check idempotency keys for dag steps - #5211
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
fix: tests + cleanup fix: naming fix: naming
mrkaye97
force-pushed
the
mk/dont-check-nondeterminism-for-dags
branch
from
October 14, 2026 21:34
5a80383 to
4eae4fd
Compare
Contributor
 [High impact] This PR appears safe to merge; no blocking issue remains. SummaryDAG steps now reuse log entries without comparing idempotency keys, allowing replay when input bytes differ.
Reviews (2) · Last reviewed commit: "fix: more naming" · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
juliusgeo
approved these changes
Oct 14, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since we're orchestrating DAGs internally, we know there's no risk of non-determinism, so we don't need to bother checking idempotency keys. This also simplifies future payload work, so figured it'd make sense to do now
Type of change
Checklist
Changes have been:
🤖 AI Disclosure
No AI