Skip to content

chore(engine): add exhaustiveness and sum type checking linters - #5221

Merged
mrkaye97 merged 7 commits into
mainfrom
mk/exhaustiveness-check-linter
Oct 15, 2026
Merged

mrkaye97 merged 7 commits into
mainfrom
mk/exhaustiveness-check-linter

Conversation

@mrkaye97

Copy link
Copy Markdown
Contributor

Description

Trying to help myself sleep at night more - exhaustiveness linters so if you miss a case in a switch you'll get yelled at.

Type of change

  • Chore (changes which are not directly related to any business logic)

Checklist

Changes have been:

  • Documented (where applicable)
  • Added to CHANGELOG (where applicable) -- see Keep a Changelog

🤖 AI Disclosure
  • I acknowledge that an LLM was used in the creation of this Pull Request, in accordance with Hatchet's AI_POLICY.md.
  • Details: Fable to fix all the issues

@vercel

vercel Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hatchet-docs Ready Ready Preview Oct 15, 2026 9:48pm UTC

Request Review

@github-actions github-actions Bot added the engine Related to the core Hatchet engine label Oct 15, 2026
@greptile-apps

greptile-apps Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Enables exhaustive and gochecksumtype and makes existing switch behavior explicit.

  • Go linting now flags switches that leave enum values unstated.

Reviews (1) · Last reviewed commit: "fix: rm map checks" · Reviewed by Greptile

@mrkaye97
mrkaye97 merged commit c205f59 into main Oct 15, 2026
61 checks passed
@mrkaye97
mrkaye97 deleted the mk/exhaustiveness-check-linter branch October 15, 2026 22:54

This branch was successfully deployed

1 active deployment
Preview — 7b8b7f26 Deployed Oct 15, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine Related to the core Hatchet engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants