fix: skip .S compiles for msvc/windows - #261
Open
zaucy wants to merge 1 commit into
Open
Conversation
helly25
added a commit
to helly25/bazel-compile-commands-extractor
that referenced
this pull request
May 17, 2026
Libraries that include .S assembly files run them through MSVC MASM (ml.exe / ml64.exe), which doesn't produce a usable header-dependency output. Trying to parse its output crashed with `AssertionError: Something went wrong in makefile parsing...`. Detect the assembler and skip header extraction for it. Backport of hedronvision#261 (zaucy).
|
Hi — since upstream has been quiet for a while, the fork at https://github.com/helly25/bazel-compile-commands-extractor has picked up this change as part of a viability sweep. Backported (with attribution preserved in the commit message) in helly25#7. Thanks for the original patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting this error while compiling libraries that use
.Sas input files which run through msvc masm compiler. Just adding the skip works for me.