Skip to content

fix: skip .S compiles for msvc/windows - #261

Open
zaucy wants to merge 1 commit into
hedronvision:mainfrom
zaucy:fix/masm-skip
Open

fix: skip .S compiles for msvc/windows#261
zaucy wants to merge 1 commit into
hedronvision:mainfrom
zaucy:fix/masm-skip

Conversation

@zaucy

@zaucy zaucy commented Sep 12, 2025

Copy link
Copy Markdown

I was getting this error while compiling libraries that use .S as input files which run through msvc masm compiler. Just adding the skip works for me.

AssertionError: Something went wrong in makefile parsing to get headers. The target should be an object file. Output:
MASM : warning A4018:invalid command-line option : /bigobj
MASM : warning A4018:invalid command-line option : /Zm500
MASM : warning A4018:invalid command-line option : /Z500
MASM : warning A4018:invalid command-line option : /Z00
MASM : warning A4018:invalid command-line option : /Z0
MASM : warning A4018:invalid command-line option : /EHsc
MASM : warning A4018:invalid command-line option : /wd4351
MASM : warning A4018:invalid command-line option : /wd4291
MASM : warning A4018:invalid command-line option : /wd4250
MASM : warning A4018:invalid command-line option : /wd4996
MASM : warning A4018:invalid command-line option : /showIncludes
 Assembling: bazel-out/x64_windows-fastbuild/bin/external/boost.context+/src/asm/jump_x86_64_ms_pe_masm.S
bazel-out/x64_windows-fastbuild/bin/external/boost.context+/src/asm/jump_x86_64_ms_pe_masm.S(1) : fatal error A1000:cannot open file : bazel-out/x64_windows-fastbuild/bin/external/boost.context+/_objs/boost.context/jump_x86_64_ms_pe_masm.obj   

helly25 added a commit to helly25/bazel-compile-commands-extractor that referenced this pull request May 17, 2026
Libraries that include .S assembly files run them through MSVC MASM
(ml.exe / ml64.exe), which doesn't produce a usable header-dependency
output. Trying to parse its output crashed with
`AssertionError: Something went wrong in makefile parsing...`.
Detect the assembler and skip header extraction for it.

Backport of hedronvision#261 (zaucy).
@helly25

helly25 commented May 17, 2026

Copy link
Copy Markdown

Hi — since upstream has been quiet for a while, the fork at https://github.com/helly25/bazel-compile-commands-extractor has picked up this change as part of a viability sweep.

Backported (with attribution preserved in the commit message) in helly25#7. Thanks for the original patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants