Skip to content

Unlock symfony 7 - #37

Open
rabauss wants to merge 2 commits into
heimrichhannot:v3from
rabauss:feature/contao-5.7
Open

rabauss wants to merge 2 commits into
heimrichhannot:v3from
rabauss:feature/contao-5.7

Conversation

@rabauss

@rabauss rabauss commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

Contao 5.7 requires Symfony 7, which this bundle's constraints currently rule out.

Symfony 7 (df2fd82)

Six constraints in composer.json are widened from ^6.4 to ^6.4 || ^7.0:

symfony/config, symfony/console, symfony/dependency-injection, symfony/event-dispatcher, symfony/http-foundation, symfony/http-kernel

The change is purely additive — Symfony 6.4 stays supported, so nothing breaks for existing installations. No source changes were needed; the APIs in use are unchanged between 6.4 and 7.0.

Caveat, unchanged from the original description: this has only been smoke-tested, not run through a full Contao 5.7 installation. Treat it as "unblocks installation", not "verified on 5.7".

Coding standard (547adfd)

A second commit was added to this branch: a plain vendor/bin/ecs --fix run over the existing files, 63 files, formatting only, no behaviour change.

Why it is here: ECS had started failing in CI on files untouched by this PR. The cause is time, not code — the repository's dev tooling is unpinned (contao/contao-rector is required as dev-main, rector/rector as ^2.3), so newly resolved versions changed what the checkers flag. The same commits passed in March.

The changes are what the repository's own ecs.php produces: docblock separation and summaries, array indentation, standalone-line promoted properties, method chaining newlines, and line endings. Nothing hand-written.

If you would rather keep this PR to the Symfony change alone, I can split the ECS commit into its own PR — just say so.

Known CI failure: rector

rector fails, and does so independently of both commits:

[ERROR] Undefined constant
        Rector\Doctrine\Set\DoctrineSetList::DOCTRINE_ORM_214

It fails while loading its configuration, before analysing a single file — hence no file list in the log. The constant no longer exists in current rector/rector-doctrine; it reaches the config through the Contao sets in rector.php. Since contao/contao-rector is dev-main, CI resolves a version without it, and the failure appeared without any change on our side.

Fixing it means pinning contao/contao-rector to a stable release (or committing composer.lock). I have deliberately left it alone here, as picking the version is a maintenance decision for this repository — happy to add it if you tell me which constraint you want.

Related

#38 builds on this branch and adds a GeoJSON overlay type as the replacement for the deprecated KmlLayer. Once this PR is merged, that diff reduces to its actual 13 files.

Formatting only, no behaviour change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant