Conversation
rabauss
force-pushed
the
feature/contao-5.7
branch
from
August 15, 2026 05:33
e0a1c5c to
547adfd
Compare
Formatting only, no behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contao 5.7 requires Symfony 7, which this bundle's constraints currently rule out.
Symfony 7 (
df2fd82)Six constraints in
composer.jsonare widened from^6.4to^6.4 || ^7.0:symfony/config,symfony/console,symfony/dependency-injection,symfony/event-dispatcher,symfony/http-foundation,symfony/http-kernelThe change is purely additive — Symfony 6.4 stays supported, so nothing breaks for existing installations. No source changes were needed; the APIs in use are unchanged between 6.4 and 7.0.
Caveat, unchanged from the original description: this has only been smoke-tested, not run through a full Contao 5.7 installation. Treat it as "unblocks installation", not "verified on 5.7".
Coding standard (
547adfd)A second commit was added to this branch: a plain
vendor/bin/ecs --fixrun over the existing files, 63 files, formatting only, no behaviour change.Why it is here: ECS had started failing in CI on files untouched by this PR. The cause is time, not code — the repository's dev tooling is unpinned (
contao/contao-rectoris required asdev-main,rector/rectoras^2.3), so newly resolved versions changed what the checkers flag. The same commits passed in March.The changes are what the repository's own
ecs.phpproduces: docblock separation and summaries, array indentation, standalone-line promoted properties, method chaining newlines, and line endings. Nothing hand-written.If you would rather keep this PR to the Symfony change alone, I can split the ECS commit into its own PR — just say so.
Known CI failure: rector
rectorfails, and does so independently of both commits:It fails while loading its configuration, before analysing a single file — hence no file list in the log. The constant no longer exists in current
rector/rector-doctrine; it reaches the config through the Contao sets inrector.php. Sincecontao/contao-rectorisdev-main, CI resolves a version without it, and the failure appeared without any change on our side.Fixing it means pinning
contao/contao-rectorto a stable release (or committingcomposer.lock). I have deliberately left it alone here, as picking the version is a maintenance decision for this repository — happy to add it if you tell me which constraint you want.Related
#38 builds on this branch and adds a GeoJSON overlay type as the replacement for the deprecated
KmlLayer. Once this PR is merged, that diff reduces to its actual 13 files.