vote own questions

Author: koertho

src/Service/QuestionService.php

@@ -4,6 +4,7 @@
 
 namespace HeimrichHannot\QnaBundle\Service;
 
+use Doctrine\DBAL\Connection;
 use HeimrichHannot\QnaBundle\Dto\QnaQuestion;
 use HeimrichHannot\QnaBundle\Dto\QnaSession;
 use HeimrichHannot\QnaBundle\Enum\SessionState;
@@ -15,6 +16,7 @@
 use HeimrichHannot\QnaBundle\Exception\SessionNotPublishedException;
 use HeimrichHannot\QnaBundle\Gateway\QnaQuestionGateway;
 use HeimrichHannot\QnaBundle\Gateway\QnaSessionGateway;
+use HeimrichHannot\QnaBundle\Gateway\QnaVoteGateway;
 use Psr\Clock\ClockInterface;
 
 final readonly class QuestionService
@@ -26,6 +28,8 @@ public function __construct(
         private ClockInterface $clock,
         private int $maxQuestionLength,
         private int $questionCooldown,
+        private QnaVoteGateway $voteGateway,
+        private Connection $connection,
     ) {
     }
 
@@ -53,9 +57,12 @@ public function create(int $sessionId, string $question): QnaQuestion
             throw new QuestionCooldownException($this->questionCooldown - ($timestamp - $latestCreatedAt));
         }
 
-        $questionId = $this->questionGateway->create($session->id, $memberId, $question, $timestamp);
+        return $this->connection->transactional(function () use ($session, $memberId, $question, $timestamp): QnaQuestion {
+            $questionId = $this->questionGateway->create($session->id, $memberId, $question, $timestamp);
+            $this->voteGateway->create($questionId, $memberId, $timestamp);
 
-        return new QnaQuestion($questionId, $session->id, $memberId, $question, $timestamp);
+            return new QnaQuestion($questionId, $session->id, $memberId, $question, $timestamp);
+        });
     }
 
     private function requireOpenSession(int $sessionId): QnaSession

tests/Integration/QuestionAnswerDatabaseTest.php

@@ -13,6 +13,7 @@
 use HeimrichHannot\QnaBundle\Gateway\QnaVoteGateway;
 use HeimrichHannot\QnaBundle\Service\FrontendMemberProvider;
 use HeimrichHannot\QnaBundle\Service\QuestionAnswerService;
+use HeimrichHannot\QnaBundle\Service\QuestionService;
 use HeimrichHannot\QnaBundle\Service\VoteService;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
@@ -50,6 +51,57 @@ protected function tearDown(): void
         $this->connection->close();
     }
 
+    public function testNewQuestionIncludesAuthorVoteAndCannotBeVotedTwice(): void
+    {
+        $question = $this->questionService(new QnaVoteGateway($this->connection))->create($this->sessionId, 'Automatically voted question');
+
+        try {
+            $votes = new QnaVoteGateway($this->connection);
+            self::assertSame(1, $votes->getState($question->id, 2147483647)->voteCount);
+            self::assertTrue($votes->getState($question->id, 2147483647)->hasVoted);
+            self::assertFalse($votes->getState($question->id, 2147483646)->hasVoted);
+            self::assertSame(1, $this->voteService()->vote($question->id, $this->sessionId)->voteCount);
+            self::assertSame(2, $this->voteService(2147483646)->vote($question->id, $this->sessionId)->voteCount);
+        } finally {
+            $this->connection->delete('tl_qna_vote', ['pid' => $question->id]);
+        }
+    }
+
+    public function testFailedAuthorVoteRollsBackQuestion(): void
+    {
+        $votes = $this->createMock(QnaVoteGateway::class);
+        $votes->expects(self::once())->method('create')->willThrowException(new \RuntimeException('Vote insert failed'));
+
+        try {
+            $this->questionService($votes)->create($this->sessionId, 'Must be rolled back');
+            self::fail('Expected vote failure.');
+        } catch (\RuntimeException $exception) {
+            self::assertSame('Vote insert failed', $exception->getMessage());
+        }
+
+        self::assertFalse($this->connection->isTransactionActive());
+        self::assertCount(1, (new QnaQuestionGateway($this->connection))->findForStage($this->sessionId));
+    }
+
+    private function questionService(QnaVoteGateway $votes): QuestionService
+    {
+        $member = $this->createStub(FrontendUser::class);
+        $member->method('__get')->willReturn(2147483647);
+        $security = $this->createStub(Security::class);
+        $security->method('getUser')->willReturn($member);
+
+        return new QuestionService(
+            new QnaSessionGateway($this->connection),
+            new QnaQuestionGateway($this->connection),
+            new FrontendMemberProvider($security),
+            new MockClock('@150'),
+            500,
+            20,
+            $votes,
+            $this->connection,
+        );
+    }
+
     public function testMarkUndoPreservesVotesAndRestoresVoting(): void
     {
         $questions = new QnaQuestionGateway($this->connection);

tests/Unit/QnaActionControllerTest.php

@@ -201,6 +201,8 @@ public function testCreatedQuestionRedirectsToAListUpdateThatResetsTheForm(): vo
             new MockClock('@150'),
             500,
             20,
+            $this->createStub(QnaVoteGateway::class),
+            $this->transactionConnection(),
         );
         $urlGenerator = $this->createMock(UrlGeneratorInterface::class);
         $urlGenerator->expects(self::once())
@@ -240,6 +242,8 @@ public function testRejectedQuestionReturnsUnprocessableReaderFrame(): void
             new MockClock('@150'),
             500,
             20,
+            $this->createStub(QnaVoteGateway::class),
+            $this->transactionConnection(),
         );
         $controller = new QnaActionController(
             $questionService,
@@ -311,6 +315,8 @@ public function testMissingAuthenticationKeepsUnauthorizedStatus(): void
             new MockClock('@150'),
             500,
             20,
+            $this->createStub(QnaVoteGateway::class),
+            $this->transactionConnection(),
         );
         $controller = new QnaActionController(
             $questionService,

tests/Unit/QuestionServiceTest.php

@@ -5,6 +5,7 @@
 namespace HeimrichHannot\QnaBundle\Tests\Unit;
 
 use Contao\FrontendUser;
+use Doctrine\DBAL\Connection;
 use HeimrichHannot\QnaBundle\Dto\QnaSession;
 use HeimrichHannot\QnaBundle\Enum\SessionState;
 use HeimrichHannot\QnaBundle\Exception\AuthenticationRequiredException;
@@ -15,6 +16,7 @@
 use HeimrichHannot\QnaBundle\Exception\SessionNotPublishedException;
 use HeimrichHannot\QnaBundle\Gateway\QnaQuestionGateway;
 use HeimrichHannot\QnaBundle\Gateway\QnaSessionGateway;
+use HeimrichHannot\QnaBundle\Gateway\QnaVoteGateway;
 use HeimrichHannot\QnaBundle\Service\FrontendMemberProvider;
 use HeimrichHannot\QnaBundle\Service\QuestionService;
 use PHPUnit\Framework\Attributes\DataProvider;
@@ -36,7 +38,10 @@ public function testCreatesTrimmedQuestionForMemberFromSecurityContext(): void
             ->with(12, 42, 'How does this work?', 1_700_000_000)
             ->willReturn(99);
 
-        $question = $this->service($sessionGateway, $questionGateway)->create(12, '  How does this work?  ');
+        $votes = $this->createMock(QnaVoteGateway::class);
+        $votes->expects(self::once())->method('create')->with(99, 42, 1_700_000_000);
+
+        $question = $this->service($sessionGateway, $questionGateway, voteGateway: $votes)->create(12, '  How does this work?  ');
 
         self::assertSame(99, $question->id);
         self::assertSame(42, $question->memberId);
@@ -131,6 +136,7 @@ private function service(
         QnaQuestionGateway $questionGateway,
         ?int $memberId = 42,
         int $maxQuestionLength = 500,
+        ?QnaVoteGateway $voteGateway = null,
     ): QuestionService {
         $security = $this->createStub(Security::class);
 
@@ -142,13 +148,22 @@ private function service(
             $security->method('getUser')->willReturn($member);
         }
 
+        $connection = $this->createStub(Connection::class);
+        $connection->method('transactional')->willReturnCallback(static fn (callable $callback): mixed => $callback());
+        if (null === $voteGateway) {
+            $voteGateway = $this->createMock(QnaVoteGateway::class);
+            $voteGateway->expects(self::never())->method('create');
+        }
+
         return new QuestionService(
             $sessionGateway,
             $questionGateway,
             new FrontendMemberProvider($security),
             $this->clock(),
             $maxQuestionLength,
             20,
+            $voteGateway,
+            $connection,
         );
     }