fix doctrine deprecation, update tests

Author: koertho

.github/workflows/ci.yml

@@ -78,6 +78,8 @@ jobs:
 
       - name: Install the dependencies
         uses: ramsey/composer-install@v3
+        with:
+          dependency-versions: "lowest"
 
       - name: PHPStan
         run: vendor/bin/phpstan analyse -c phpstan.neon
@@ -95,6 +97,8 @@ jobs:
 
       - name: Install the dependencies
         uses: ramsey/composer-install@v3
+        with:
+          dependency-versions: "lowest"
 
       - name: Rector
         run: vendor/bin/rector --dry-run --no-progress-bar

src/Command/EntityFinderCommand.php

@@ -242,11 +242,11 @@ private function runLegacyExtendEntityFinderEvent(string $table, $id, array $par
 
     private function findInserttags(ExtendEntityFinderEvent $event): void
     {
-        $stmt = $this->connection->prepare(
-            "SELECT id FROM tl_module WHERE type='html' AND html LIKE ?");
-
         foreach ($event->getInserttags() as $inserttag) {
-            $result = $stmt->executeQuery(['%'.$inserttag.'%']);
+            $result = $this->connection->executeQuery(
+                "SELECT id FROM tl_module WHERE type='html' AND html LIKE ?",
+                ['%'.$inserttag.'%']
+            );
 
             foreach ($result->fetchAllAssociative() as $row) {
                 $event->addParent(ModuleModel::getTable(), $row['id']);

src/EventListener/DcaField/AliasDcaFieldListener.php

@@ -46,7 +46,6 @@ public function onFieldsAliasSaveCallback($value, DataContainer $dc)
             /**
              * Contao 4 fallback
              * @todo Remove when contao 5 only
-             * @phpstan-ignore property.notFound
              */
             $row = $dc->activeRecord?->row() ?? [];
         }

src/Util/RoutingUtil.php

@@ -39,9 +39,6 @@ public function __construct(
      *     route?: string
      * } $options Options
      *
-     * @throws ContainerExceptionInterface
-     * @throws NotFoundExceptionInterface
-     *
      * @return string The backend route url
      */
     public function generateBackendRoute(array $params = [], bool $addToken = true, bool $addReferer = true, array $options = []): string