run ecs

Author: koertho

src/Context/Gender/Gender.php

@@ -13,7 +13,7 @@ enum Gender: string implements GenderInterface
     public function build(): SalutationPartResult
     {
         return new SalutationPartResult(
-            'gender.' . $this->value,
+            'gender.'.$this->value,
             domain: 'salutation_creator',
             fallback: ucfirst($this->value),
         );

src/Context/Name/GermanTypeName.php

@@ -12,7 +12,7 @@ public function __construct(
 
     public function getFullName(): string
     {
-        return $this->firstName . ' ' . $this->lastName;
+        return $this->firstName.' '.$this->lastName;
     }
 
     public function getFormalName(): string

src/Parser/Name/AbstractParser.php

@@ -13,13 +13,13 @@ abstract class AbstractParser
 
     /**
      * @param class-string<RuleInterface>[] $rules
-     * @param class-string<AbstractName> $format
+     * @param class-string<AbstractName>    $format
      */
     final public function __construct(
         protected array $rules,
         protected string $format,
     ) {
-        if (!(is_a($this->format, AbstractName::class, true))) {
+        if (!is_a($this->format, AbstractName::class, true)) {
             throw new \InvalidArgumentException(sprintf('Format class "%s" does not exist or is not a subclass of "%s".', $this->format, AbstractName::class));
         }
     }
@@ -33,12 +33,14 @@ public static function create(string $format): static
         $rules = static::defaultRules($format);
 
         $instance = new static($rules, $format);
+
         return $instance;
     }
 
     public function allowIncomplete(bool $allow): static
     {
         $this->allowIncomplete = $allow;
+
         return $this;
     }
 
@@ -71,4 +73,4 @@ protected function buildNameFromResult(Result $result): ?AbstractName
      * @return class-string<RuleInterface>[]
      */
     abstract public static function defaultRules(string $format): array;
-}
+}

src/Parser/Name/ArrayParser.php

@@ -21,10 +21,10 @@ public function parse(array $data): ?AbstractName
         foreach ($data as $key => $value) {
             $entry = new RowValue($key, $value);
             foreach ($this->rules as $rule) {
-                if (!(is_a($rule, RuleInterface::class, true))) {
+                if (!is_a($rule, RuleInterface::class, true)) {
                     continue;
                 }
-                $result->with((new $rule)->apply($entry));
+                $result->with((new $rule())->apply($entry));
                 if ($result->isComplete()) {
                     break 2;
                 }
@@ -36,6 +36,7 @@ public function parse(array $data): ?AbstractName
 
     /**
      * @param class-string<AbstractName> $format
+     *
      * @return class-string<RuleInterface>[]
      */
     public static function defaultRules(string $format): array
@@ -50,4 +51,4 @@ public static function defaultRules(string $format): array
             ],
         };
     }
-}
+}

src/Parser/Name/Rule/Array/EnglishKeyNameRule.php

@@ -3,23 +3,23 @@
 namespace HeimrichHannot\SalutationCreator\Parser\Name\Rule\Array;
 
 use HeimrichHannot\SalutationCreator\Parser\Name\Rule\Result;
-use HeimrichHannot\SalutationCreator\Parser\Name\Rule\RuleInterface;
 use HeimrichHannot\SalutationCreator\Parser\Name\Rule\RowValue;
+use HeimrichHannot\SalutationCreator\Parser\Name\Rule\RuleInterface;
 use HeimrichHannot\SalutationCreator\Parser\Name\Rule\Value;
 
 class EnglishKeyNameRule implements RuleInterface
 {
     public function apply(Value $value): Result
     {
-        if (!($value instanceof RowValue)) {
+        if (!$value instanceof RowValue) {
             return new Result(false);
         }
 
         if (!is_string($value->originalValue)) {
             return new Result(false);
         }
 
-        if ($value->normalizedKey === 'firstname') {
+        if ('firstname' === $value->normalizedKey) {
             return new Result(true, firstName: $value->originalValue, origin: $value);
         }
         if (\in_array($value->normalizedKey, ['lastname', 'name'])) {
@@ -28,4 +28,4 @@ public function apply(Value $value): Result
 
         return new Result(false);
     }
-}
+}

src/Parser/Name/Rule/Array/GermanKeyNameRule.php

@@ -11,7 +11,7 @@ class GermanKeyNameRule implements RuleInterface
 {
     public function apply(Value $value): Result
     {
-        if (!($value instanceof RowValue)) {
+        if (!$value instanceof RowValue) {
             return new Result(false);
         }
 
@@ -28,4 +28,4 @@ public function apply(Value $value): Result
 
         return new Result(false);
     }
-}
+}

src/Parser/Name/Rule/Result.php

@@ -5,11 +5,12 @@
 class Result
 {
     public function __construct(
-        public readonly bool   $matched,
+        public readonly bool $matched,
         public readonly string $firstName = '',
         public readonly string $lastName = '',
-        public readonly mixed  $origin = null,
-    ) {}
+        public readonly mixed $origin = null,
+    ) {
+    }
 
     public function with(Result $result): Result
     {
@@ -19,19 +20,19 @@ public function with(Result $result): Result
 
         return new self(
             true,
-            $result->firstName !== '' ? $result->firstName : $this->firstName,
-            $result->lastName !== '' ? $result->lastName : $this->lastName,
+            '' !== $result->firstName ? $result->firstName : $this->firstName,
+            '' !== $result->lastName ? $result->lastName : $this->lastName,
             $this->origin // oder $result->origin, je nach gewünschter Semantik
         );
     }
 
     public function isComplete(): bool
     {
-        return $this->matched && $this->firstName !== '' && $this->lastName !== '';
+        return $this->matched && '' !== $this->firstName && '' !== $this->lastName;
     }
 
     public function isEmpty(): bool
     {
-        return $this->firstName === '' && $this->lastName === '';
+        return '' === $this->firstName && '' === $this->lastName;
     }
-}
+}

src/Parser/Name/Rule/RowValue.php

@@ -9,11 +9,11 @@ class RowValue extends Value
 
     public function __construct(
         string|int $key,
-        mixed $value
+        mixed $value,
     ) {
         parent::__construct($value);
 
         $this->originalKey = (string) $key;
         $this->normalizedKey = strtolower((string) preg_replace('/[^a-z0-9]/i', '', $this->originalKey));
     }
-}
+}

src/Parser/Name/Rule/RuleInterface.php

@@ -2,10 +2,7 @@
 
 namespace HeimrichHannot\SalutationCreator\Parser\Name\Rule;
 
-use HeimrichHannot\SalutationCreator\Parser\Name\Rule\Result;
-use HeimrichHannot\SalutationCreator\Parser\Name\Rule\Value;
-
 interface RuleInterface
 {
     public function apply(Value $value): Result;
-}
+}

src/Parser/Name/Rule/Value.php

@@ -4,9 +4,8 @@
 
 class Value
 {
-    public function __construct(public mixed $originalValue)
-    {
+    public function __construct(
+        public mixed $originalValue,
+    ) {
     }
-
-
-}
+}