fix phpstan reports

Author: koertho

src/Parser/Name/AbstractParser.php

@@ -11,19 +11,22 @@ abstract class AbstractParser
 {
     private bool $allowIncomplete = false;
 
-    public function __construct(
-        /**
-         * @var class-string<RuleInterface>[]
-         */
+    /**
+     * @param class-string<RuleInterface>[] $rules
+     * @param class-string<AbstractName> $format
+     */
+    final public function __construct(
         protected array $rules,
-        /** @var class-string<AbstractName> */
         protected string $format,
     ) {
         if (!(is_a($this->format, AbstractName::class, true))) {
             throw new \InvalidArgumentException(sprintf('Format class "%s" does not exist or is not a subclass of "%s".', $this->format, AbstractName::class));
         }
     }
 
+    /**
+     * @param class-string<AbstractName> $format
+     */
     public static function create(string $format): static
     {
         static::validateFormat($format);
@@ -64,5 +67,8 @@ protected function buildNameFromResult(Result $result): ?AbstractName
         return $name;
     }
 
+    /**
+     * @return class-string<RuleInterface>[]
+     */
     abstract public static function defaultRules(string $format): array;
 }

src/Parser/Name/ArrayParser.php

@@ -12,6 +12,9 @@
 
 class ArrayParser extends AbstractParser
 {
+    /**
+     * @param array<mixed, mixed> $data
+     */
     public function parse(array $data): ?AbstractName
     {
         $result = new Result(false);
@@ -32,7 +35,7 @@ public function parse(array $data): ?AbstractName
     }
 
     /**
-     * @param string $format
+     * @param class-string<AbstractName> $format
      * @return class-string<RuleInterface>[]
      */
     public static function defaultRules(string $format): array

src/Parser/Name/Rule/Array/GermanKeyNameRule.php

@@ -4,9 +4,10 @@
 
 use HeimrichHannot\SalutationCreator\Parser\Name\Rule\Result;
 use HeimrichHannot\SalutationCreator\Parser\Name\Rule\RowValue;
+use HeimrichHannot\SalutationCreator\Parser\Name\Rule\RuleInterface;
 use HeimrichHannot\SalutationCreator\Parser\Name\Rule\Value;
 
-class GermanKeyNameRule
+class GermanKeyNameRule implements RuleInterface
 {
     public function apply(Value $value): Result
     {

src/Parser/Name/Rule/RowValue.php

@@ -8,7 +8,7 @@ class RowValue extends Value
     public string $normalizedKey;
 
     public function __construct(
-        mixed $key,
+        string|int $key,
         mixed $value
     ) {
         parent::__construct($value);

src/Parser/Name/StringParser.php

@@ -28,7 +28,9 @@ public function parse(string $name): ?AbstractName
         }
 
         $parts = preg_split('/\s+/u', $name, -1, PREG_SPLIT_NO_EMPTY);
-        $count = count($parts);
+        if (false === $parts || ($count = count($parts)) === 0) {
+            return null;
+        }
 
         if ($count === 1) {
             return $this->buildNameFromResult(new Result(true, '', $parts[0]));