phpstan level 10

Author: koertho

CHANGELOG.md

@@ -2,5 +2,5 @@
 
 All notable changes to this project will be documented in this file.
 
-## [0.1.0] - 2024-09-03
+## [0.1.0] - 2025-12-09
 Initial release

phpstan.neon

@@ -1,10 +1,5 @@
 parameters:
-  level: 1
+  level: 10
+  treatPhpDocTypesAsCertain: false
   paths:
-    - src
-#    - contao
-#  universalObjectCratesClasses:
-#    - Contao\Model
-#    - Contao\Template
-includes:
-  - vendor/phpstan/phpstan-symfony/extension.neon
+    - src

src/Context/Gender/Gender.php

@@ -24,6 +24,9 @@ public function getKey(): string
         return $this->value;
     }
 
+    /**
+     * @return array<string, GenderInterface>
+     */
     public static function defaultMapping(): array
     {
         return [
@@ -46,6 +49,9 @@ public static function defaultMapping(): array
         ];
     }
 
+    /**
+     * @param array<string, GenderInterface>|null $mapping
+     */
     public static function tryFromString(string $value, ?self $fallback = null, ?array $mapping = null): ?GenderInterface
     {
         $value = strtolower(trim($value));

src/Context/Name/AbstractName.php

@@ -15,15 +15,15 @@ public function build(): SalutationPartResult
     /**
      * Return the full name, e.g. "John Doe"
      */
-    abstract function getFullName();
+    abstract function getFullName(): string;
 
     /**
      * Return the formal name, e.g. "Mr. Doe". Used for formal salutations.
      */
-    abstract function getFormalName();
+    abstract function getFormalName(): string;
 
     /**
      * Return the given name, e.g. "John". Used for informal salutations.
      */
-    abstract function getGivenName();
+    abstract function getGivenName(): string;
 }

src/Context/Name/GermanTypeName.php

@@ -9,17 +9,17 @@ public function __construct(
         private readonly string $lastName
     ) {}
 
-    function getFullName()
+    function getFullName(): string
     {
         return $this->firstName . ' ' . $this->lastName;
     }
 
-    function getFormalName()
+    function getFormalName(): string
     {
         return $this->lastName;
     }
 
-    function getGivenName()
+    function getGivenName(): string
     {
         return $this->firstName;
     }

src/Helper/Titles.php

@@ -9,6 +9,9 @@
 
 class Titles
 {
+    /**
+     * @return array<string, array{0: class-string<AbstractTitle>, 1?: non-empty-list<string>}>
+     */
     public static function defaultMapping(): array
     {
         return [
@@ -29,7 +32,7 @@ public static function defaultMapping(): array
 
     /**
      * @param string $value
-     * @param array|null $mapping Override the default string title mapping
+     * @param array<string, array{0: class-string<AbstractTitle>, 1?: non-empty-list<string>}>|null $mapping Override the default string title mapping
      * @return AbstractTitle[]
      */
     public static function fromString(string $value, ?array $mapping = null): array
@@ -54,7 +57,9 @@ public static function fromString(string $value, ?array $mapping = null): array
                 continue;
             }
 
-            $titles[] = new $mapping[$key][0](...($mapping[$key][1] ?? []));
+            /** @var AbstractTitle $title */
+            $title = new $mapping[$key][0](...($mapping[$key][1] ?? []));
+            $titles[] = $title;
         }
 
         return $titles;

src/SalutationContext.php

@@ -42,6 +42,10 @@ public function addTitle(AbstractTitle $title): self
         return $this;
     }
 
+    /**
+     * @param AbstractTitle[] $titles
+     * @return $this
+     */
     public function addTitles(array $titles): self
     {
         foreach ($titles as $title) {

src/SalutationCreator.php

@@ -33,9 +33,9 @@ public function generate(SalutationContext $context): string
             '%suffix_titles%' => $suffixTitles,
             '%gender_name%' => $context->getGender()->build()->trans($this->translator),
             '%gender%' => $context->getGender()->getKey(),
-            '%name%' => $context->getName()->getFullName(),
-            '%formal_name%' => $context->getName()->getFormalName(),
-            '%given_name%' => $context->getName()->getGivenName(),
+            '%name%' => $context->getName()?->getFullName() ?? '',
+            '%formal_name%' => $context->getName()?->getFormalName() ?? '',
+            '%given_name%' => $context->getName()?->getGivenName() ?? '',
         ];
 
         return trim($this->translator->trans(
@@ -46,12 +46,16 @@ public function generate(SalutationContext $context): string
 
     }
 
+    /**
+     * @param array<SalutationPartInterface|array<SalutationPartInterface>> $array
+     * @return string
+     */
     private function buildString(array $array): string
     {
         $string = '';
         array_walk_recursive($array, function ($value) use (&$string) {
             /**
-             * @var AbstractTitle $value
+             * @var SalutationPartInterface $value
              */
             $string .= $value->build()->trans($this->translator);
         });

src/SalutationPartResult.php

@@ -7,6 +7,9 @@
 
 readonly class SalutationPartResult implements TranslatableInterface, \Stringable
 {
+    /**
+     * @param array<string,string|int|TranslatableInterface> $parameters
+     */
     public function __construct(
         private string  $message,
         private array   $parameters = [],
@@ -25,6 +28,9 @@ public function getMessage(): string
         return $this->message;
     }
 
+    /**
+     * @return array<string,string|int|TranslatableInterface>
+     */
     public function getParameters(): array
     {
         return $this->parameters;