Use npm trusted publishing for package releases - #190
Merged
Merged
Conversation
mchatlas-hellosign
marked this pull request as ready for review
September 14, 2026 10:46
mwojcik-dropbox
approved these changes
Sep 14, 2026
|
Hey folks. Can the admin for this repo remove the github user ericbecking
from notifications? I no longer work for dropbox so it's kind of weird to
be receiving these emails.
…On Mon, Sep 14, 2026 at 3:53 AM mchatlas-hellosign ***@***.***> wrote:
Merged #190 <#190>
into main.
—
Reply to this email directly, view it on GitHub
<#190?email_source=notifications&email_token=AADYHMMJGSIQLVB7BFFOCJD5O7EZLA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTGMJQHE2DKNRZHA4DJJTSMVQXG33OVJZXKYTTMNZGSYTFMSSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#event-31094569884>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADYHMPSRBXHKVLSL3MSKMT5O7EZLAVCNFSNUABEKJSXA33TNF2G64TZHM2DIMJZGQZTEOB3JFZXG5LFHM2TIMRUHA2DCNZTGGQXMAQ>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AADYHMIFEBFA7UAIZCT2NAD5O7EZLA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTGMJQHE2DKNRZHA4DJJTSMVQXG33OVJZXKYTTMNZGSYTFMSSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/AADYHMOXBXFEUW3IPAHP6UD5O7EZLA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTGMJQHE2DKNRZHA4DJJTSMVQXG33OVJZXKYTTMNZGSYTFMSSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***
com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainthat changepackage.json, with an additional event/ref guard on every jobWorkflow structure
buildvalidates and packages the release on Node 16, then uploads a one-day workflow artifact.publishdownloads that artifact and publishes it through npm OIDC.releaseruns only after npm succeeds, creates the GitHub Release, and deploys the same build artifacts to the production CDN through the existing AWS OIDC role.The workflow has no GitHub environment dependency. Publishing is gated in code by the
mainpush trigger, thepackage.jsonpath filter, and job-level event/ref conditions.Validation
2.12.3-oidc-test.1.2from this workflow with no npm tokenactionlintv1.7.12 passed on the consolidated workflowgit diff --checkpassesRelease follow-up
2.12.3-oidc-test.1.2package after inspectionnpm publishmain, and the latest GitHub Release are2.12.3; an orphanedv2.12.4tag already exists outsidemain2.12.4version PR and replace the old tag immediately before merging that releaseThe workflow filename remains
github-actions.yml, matching npm's trusted-publisher configuration.