Skip to content

Commit 05e0708

Browse files
adanilowski-dropboxclaude
adanilowski-dropbox
and
claude
authored
Fix Ruby SDK silently swallowing API errors (SIGN-17019) (#553)
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 31136f9 commit 05e0708

14 files changed

Lines changed: 214 additions & 67 deletions

‎sdks/ruby/lib/dropbox-sign/api/account_api.rb‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ def account_create_with_http_info(account_create_request, opts = {})
111111
range_code = "4XX".split('').first
112112
range_code_left = "#{range_code}00".to_i
113113
range_code_right = "#{range_code}99".to_i
114-
if e.code >= range_code_left && e.code <= range_code_right
114+
if e.code && e.code >= range_code_left && e.code <= range_code_right
115115
body = @api_client.convert_to_type(
116116
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
117117
"Dropbox::Sign::ErrorResponse"
@@ -123,6 +123,7 @@ def account_create_with_http_info(account_create_request, opts = {})
123123
e.message
124124
end
125125

126+
raise e
126127
end
127128

128129
if @api_client.config.debugging
@@ -205,7 +206,7 @@ def account_get_with_http_info(opts = {})
205206
range_code = "4XX".split('').first
206207
range_code_left = "#{range_code}00".to_i
207208
range_code_right = "#{range_code}99".to_i
208-
if e.code >= range_code_left && e.code <= range_code_right
209+
if e.code && e.code >= range_code_left && e.code <= range_code_right
209210
body = @api_client.convert_to_type(
210211
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
211212
"Dropbox::Sign::ErrorResponse"
@@ -217,6 +218,7 @@ def account_get_with_http_info(opts = {})
217218
e.message
218219
end
219220

221+
raise e
220222
end
221223

222224
if @api_client.config.debugging
@@ -314,7 +316,7 @@ def account_update_with_http_info(account_update_request, opts = {})
314316
range_code = "4XX".split('').first
315317
range_code_left = "#{range_code}00".to_i
316318
range_code_right = "#{range_code}99".to_i
317-
if e.code >= range_code_left && e.code <= range_code_right
319+
if e.code && e.code >= range_code_left && e.code <= range_code_right
318320
body = @api_client.convert_to_type(
319321
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
320322
"Dropbox::Sign::ErrorResponse"
@@ -326,6 +328,7 @@ def account_update_with_http_info(account_update_request, opts = {})
326328
e.message
327329
end
328330

331+
raise e
329332
end
330333

331334
if @api_client.config.debugging
@@ -423,7 +426,7 @@ def account_verify_with_http_info(account_verify_request, opts = {})
423426
range_code = "4XX".split('').first
424427
range_code_left = "#{range_code}00".to_i
425428
range_code_right = "#{range_code}99".to_i
426-
if e.code >= range_code_left && e.code <= range_code_right
429+
if e.code && e.code >= range_code_left && e.code <= range_code_right
427430
body = @api_client.convert_to_type(
428431
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
429432
"Dropbox::Sign::ErrorResponse"
@@ -435,6 +438,7 @@ def account_verify_with_http_info(account_verify_request, opts = {})
435438
e.message
436439
end
437440

441+
raise e
438442
end
439443

440444
if @api_client.config.debugging

‎sdks/ruby/lib/dropbox-sign/api/api_app_api.rb‎

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ def api_app_create_with_http_info(api_app_create_request, opts = {})
111111
range_code = "4XX".split('').first
112112
range_code_left = "#{range_code}00".to_i
113113
range_code_right = "#{range_code}99".to_i
114-
if e.code >= range_code_left && e.code <= range_code_right
114+
if e.code && e.code >= range_code_left && e.code <= range_code_right
115115
body = @api_client.convert_to_type(
116116
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
117117
"Dropbox::Sign::ErrorResponse"
@@ -123,6 +123,7 @@ def api_app_create_with_http_info(api_app_create_request, opts = {})
123123
e.message
124124
end
125125

126+
raise e
126127
end
127128

128129
if @api_client.config.debugging
@@ -190,6 +191,7 @@ def api_app_delete_with_http_info(client_id, opts = {})
190191
begin
191192
data, status_code, headers = @api_client.call_api(:DELETE, local_var_path, new_options)
192193
rescue Dropbox::Sign::ApiError => e
194+
raise e
193195
end
194196

195197
if @api_client.config.debugging
@@ -272,7 +274,7 @@ def api_app_get_with_http_info(client_id, opts = {})
272274
range_code = "4XX".split('').first
273275
range_code_left = "#{range_code}00".to_i
274276
range_code_right = "#{range_code}99".to_i
275-
if e.code >= range_code_left && e.code <= range_code_right
277+
if e.code && e.code >= range_code_left && e.code <= range_code_right
276278
body = @api_client.convert_to_type(
277279
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
278280
"Dropbox::Sign::ErrorResponse"
@@ -284,6 +286,7 @@ def api_app_get_with_http_info(client_id, opts = {})
284286
e.message
285287
end
286288

289+
raise e
287290
end
288291

289292
if @api_client.config.debugging
@@ -366,7 +369,7 @@ def api_app_list_with_http_info(opts = {})
366369
range_code = "4XX".split('').first
367370
range_code_left = "#{range_code}00".to_i
368371
range_code_right = "#{range_code}99".to_i
369-
if e.code >= range_code_left && e.code <= range_code_right
372+
if e.code && e.code >= range_code_left && e.code <= range_code_right
370373
body = @api_client.convert_to_type(
371374
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
372375
"Dropbox::Sign::ErrorResponse"
@@ -378,6 +381,7 @@ def api_app_list_with_http_info(opts = {})
378381
e.message
379382
end
380383

384+
raise e
381385
end
382386

383387
if @api_client.config.debugging
@@ -481,7 +485,7 @@ def api_app_update_with_http_info(client_id, api_app_update_request, opts = {})
481485
range_code = "4XX".split('').first
482486
range_code_left = "#{range_code}00".to_i
483487
range_code_right = "#{range_code}99".to_i
484-
if e.code >= range_code_left && e.code <= range_code_right
488+
if e.code && e.code >= range_code_left && e.code <= range_code_right
485489
body = @api_client.convert_to_type(
486490
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
487491
"Dropbox::Sign::ErrorResponse"
@@ -493,6 +497,7 @@ def api_app_update_with_http_info(client_id, api_app_update_request, opts = {})
493497
e.message
494498
end
495499

500+
raise e
496501
end
497502

498503
if @api_client.config.debugging

‎sdks/ruby/lib/dropbox-sign/api/bulk_send_job_api.rb‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ def bulk_send_job_get_with_http_info(bulk_send_job_id, opts = {})
102102
range_code = "4XX".split('').first
103103
range_code_left = "#{range_code}00".to_i
104104
range_code_right = "#{range_code}99".to_i
105-
if e.code >= range_code_left && e.code <= range_code_right
105+
if e.code && e.code >= range_code_left && e.code <= range_code_right
106106
body = @api_client.convert_to_type(
107107
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
108108
"Dropbox::Sign::ErrorResponse"
@@ -114,6 +114,7 @@ def bulk_send_job_get_with_http_info(bulk_send_job_id, opts = {})
114114
e.message
115115
end
116116

117+
raise e
117118
end
118119

119120
if @api_client.config.debugging
@@ -196,7 +197,7 @@ def bulk_send_job_list_with_http_info(opts = {})
196197
range_code = "4XX".split('').first
197198
range_code_left = "#{range_code}00".to_i
198199
range_code_right = "#{range_code}99".to_i
199-
if e.code >= range_code_left && e.code <= range_code_right
200+
if e.code && e.code >= range_code_left && e.code <= range_code_right
200201
body = @api_client.convert_to_type(
201202
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
202203
"Dropbox::Sign::ErrorResponse"
@@ -208,6 +209,7 @@ def bulk_send_job_list_with_http_info(opts = {})
208209
e.message
209210
end
210211

212+
raise e
211213
end
212214

213215
if @api_client.config.debugging

‎sdks/ruby/lib/dropbox-sign/api/embedded_api.rb‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ def embedded_edit_url_with_http_info(template_id, embedded_edit_url_request, opt
117117
range_code = "4XX".split('').first
118118
range_code_left = "#{range_code}00".to_i
119119
range_code_right = "#{range_code}99".to_i
120-
if e.code >= range_code_left && e.code <= range_code_right
120+
if e.code && e.code >= range_code_left && e.code <= range_code_right
121121
body = @api_client.convert_to_type(
122122
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
123123
"Dropbox::Sign::ErrorResponse"
@@ -129,6 +129,7 @@ def embedded_edit_url_with_http_info(template_id, embedded_edit_url_request, opt
129129
e.message
130130
end
131131

132+
raise e
132133
end
133134

134135
if @api_client.config.debugging
@@ -211,7 +212,7 @@ def embedded_sign_url_with_http_info(signature_id, opts = {})
211212
range_code = "4XX".split('').first
212213
range_code_left = "#{range_code}00".to_i
213214
range_code_right = "#{range_code}99".to_i
214-
if e.code >= range_code_left && e.code <= range_code_right
215+
if e.code && e.code >= range_code_left && e.code <= range_code_right
215216
body = @api_client.convert_to_type(
216217
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
217218
"Dropbox::Sign::ErrorResponse"
@@ -223,6 +224,7 @@ def embedded_sign_url_with_http_info(signature_id, opts = {})
223224
e.message
224225
end
225226

227+
raise e
226228
end
227229

228230
if @api_client.config.debugging

‎sdks/ruby/lib/dropbox-sign/api/fax_api.rb‎

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ def fax_delete_with_http_info(fax_id, opts = {})
8181
begin
8282
data, status_code, headers = @api_client.call_api(:DELETE, local_var_path, new_options)
8383
rescue Dropbox::Sign::ApiError => e
84+
raise e
8485
end
8586

8687
if @api_client.config.debugging
@@ -163,7 +164,7 @@ def fax_files_with_http_info(fax_id, opts = {})
163164
range_code = "4XX".split('').first
164165
range_code_left = "#{range_code}00".to_i
165166
range_code_right = "#{range_code}99".to_i
166-
if e.code >= range_code_left && e.code <= range_code_right
167+
if e.code && e.code >= range_code_left && e.code <= range_code_right
167168
body = @api_client.convert_to_type(
168169
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
169170
"Dropbox::Sign::ErrorResponse"
@@ -175,6 +176,7 @@ def fax_files_with_http_info(fax_id, opts = {})
175176
e.message
176177
end
177178

179+
raise e
178180
end
179181

180182
if @api_client.config.debugging
@@ -257,7 +259,7 @@ def fax_get_with_http_info(fax_id, opts = {})
257259
range_code = "4XX".split('').first
258260
range_code_left = "#{range_code}00".to_i
259261
range_code_right = "#{range_code}99".to_i
260-
if e.code >= range_code_left && e.code <= range_code_right
262+
if e.code && e.code >= range_code_left && e.code <= range_code_right
261263
body = @api_client.convert_to_type(
262264
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
263265
"Dropbox::Sign::ErrorResponse"
@@ -269,6 +271,7 @@ def fax_get_with_http_info(fax_id, opts = {})
269271
e.message
270272
end
271273

274+
raise e
272275
end
273276

274277
if @api_client.config.debugging
@@ -363,7 +366,7 @@ def fax_list_with_http_info(opts = {})
363366
range_code = "4XX".split('').first
364367
range_code_left = "#{range_code}00".to_i
365368
range_code_right = "#{range_code}99".to_i
366-
if e.code >= range_code_left && e.code <= range_code_right
369+
if e.code && e.code >= range_code_left && e.code <= range_code_right
367370
body = @api_client.convert_to_type(
368371
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
369372
"Dropbox::Sign::ErrorResponse"
@@ -375,6 +378,7 @@ def fax_list_with_http_info(opts = {})
375378
e.message
376379
end
377380

381+
raise e
378382
end
379383

380384
if @api_client.config.debugging
@@ -472,7 +476,7 @@ def fax_send_with_http_info(fax_send_request, opts = {})
472476
range_code = "4XX".split('').first
473477
range_code_left = "#{range_code}00".to_i
474478
range_code_right = "#{range_code}99".to_i
475-
if e.code >= range_code_left && e.code <= range_code_right
479+
if e.code && e.code >= range_code_left && e.code <= range_code_right
476480
body = @api_client.convert_to_type(
477481
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
478482
"Dropbox::Sign::ErrorResponse"
@@ -484,6 +488,7 @@ def fax_send_with_http_info(fax_send_request, opts = {})
484488
e.message
485489
end
486490

491+
raise e
487492
end
488493

489494
if @api_client.config.debugging

‎sdks/ruby/lib/dropbox-sign/api/fax_line_api.rb‎

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ def fax_line_add_user_with_http_info(fax_line_add_user_request, opts = {})
111111
range_code = "4XX".split('').first
112112
range_code_left = "#{range_code}00".to_i
113113
range_code_right = "#{range_code}99".to_i
114-
if e.code >= range_code_left && e.code <= range_code_right
114+
if e.code && e.code >= range_code_left && e.code <= range_code_right
115115
body = @api_client.convert_to_type(
116116
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
117117
"Dropbox::Sign::ErrorResponse"
@@ -123,6 +123,7 @@ def fax_line_add_user_with_http_info(fax_line_add_user_request, opts = {})
123123
e.message
124124
end
125125

126+
raise e
126127
end
127128

128129
if @api_client.config.debugging
@@ -228,7 +229,7 @@ def fax_line_area_code_get_with_http_info(country, opts = {})
228229
range_code = "4XX".split('').first
229230
range_code_left = "#{range_code}00".to_i
230231
range_code_right = "#{range_code}99".to_i
231-
if e.code >= range_code_left && e.code <= range_code_right
232+
if e.code && e.code >= range_code_left && e.code <= range_code_right
232233
body = @api_client.convert_to_type(
233234
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
234235
"Dropbox::Sign::ErrorResponse"
@@ -240,6 +241,7 @@ def fax_line_area_code_get_with_http_info(country, opts = {})
240241
e.message
241242
end
242243

244+
raise e
243245
end
244246

245247
if @api_client.config.debugging
@@ -337,7 +339,7 @@ def fax_line_create_with_http_info(fax_line_create_request, opts = {})
337339
range_code = "4XX".split('').first
338340
range_code_left = "#{range_code}00".to_i
339341
range_code_right = "#{range_code}99".to_i
340-
if e.code >= range_code_left && e.code <= range_code_right
342+
if e.code && e.code >= range_code_left && e.code <= range_code_right
341343
body = @api_client.convert_to_type(
342344
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
343345
"Dropbox::Sign::ErrorResponse"
@@ -349,6 +351,7 @@ def fax_line_create_with_http_info(fax_line_create_request, opts = {})
349351
e.message
350352
end
351353

354+
raise e
352355
end
353356

354357
if @api_client.config.debugging
@@ -431,6 +434,7 @@ def fax_line_delete_with_http_info(fax_line_delete_request, opts = {})
431434
begin
432435
data, status_code, headers = @api_client.call_api(:DELETE, local_var_path, new_options)
433436
rescue Dropbox::Sign::ApiError => e
437+
raise e
434438
end
435439

436440
if @api_client.config.debugging
@@ -514,7 +518,7 @@ def fax_line_get_with_http_info(number, opts = {})
514518
range_code = "4XX".split('').first
515519
range_code_left = "#{range_code}00".to_i
516520
range_code_right = "#{range_code}99".to_i
517-
if e.code >= range_code_left && e.code <= range_code_right
521+
if e.code && e.code >= range_code_left && e.code <= range_code_right
518522
body = @api_client.convert_to_type(
519523
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
520524
"Dropbox::Sign::ErrorResponse"
@@ -526,6 +530,7 @@ def fax_line_get_with_http_info(number, opts = {})
526530
e.message
527531
end
528532

533+
raise e
529534
end
530535

531536
if @api_client.config.debugging
@@ -614,7 +619,7 @@ def fax_line_list_with_http_info(opts = {})
614619
range_code = "4XX".split('').first
615620
range_code_left = "#{range_code}00".to_i
616621
range_code_right = "#{range_code}99".to_i
617-
if e.code >= range_code_left && e.code <= range_code_right
622+
if e.code && e.code >= range_code_left && e.code <= range_code_right
618623
body = @api_client.convert_to_type(
619624
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
620625
"Dropbox::Sign::ErrorResponse"
@@ -626,6 +631,7 @@ def fax_line_list_with_http_info(opts = {})
626631
e.message
627632
end
628633

634+
raise e
629635
end
630636

631637
if @api_client.config.debugging
@@ -723,7 +729,7 @@ def fax_line_remove_user_with_http_info(fax_line_remove_user_request, opts = {})
723729
range_code = "4XX".split('').first
724730
range_code_left = "#{range_code}00".to_i
725731
range_code_right = "#{range_code}99".to_i
726-
if e.code >= range_code_left && e.code <= range_code_right
732+
if e.code && e.code >= range_code_left && e.code <= range_code_right
727733
body = @api_client.convert_to_type(
728734
JSON.parse("[#{e.response_body}]", :symbolize_names => true)[0],
729735
"Dropbox::Sign::ErrorResponse"
@@ -735,6 +741,7 @@ def fax_line_remove_user_with_http_info(fax_line_remove_user_request, opts = {})
735741
e.message
736742
end
737743

744+
raise e
738745
end
739746

740747
if @api_client.config.debugging

0 commit comments

Comments
 (0)