feat: add PS/2 keyboard interrupt driver - #2532
Merged
Merged
Conversation
GloriousAlpaca
force-pushed
the
pr-keyboard-clean
branch
from
July 6, 2026 15:33
7c21b3f to
5d35a06
Compare
There was a problem hiding this comment.
Benchmark Results
Details
| Benchmark | Current: 009e0fa | Previous: 2e23902 | Performance Ratio |
|---|---|---|---|
| startup_benchmark Build Time | 94.03 s |
80.34 s |
1.17 ❗ |
| startup_benchmark File Size | 0.78 MB |
0.80 MB |
0.98 ❗ |
| Startup Time - 1 core | 0.73 s (±0.01 s) |
0.75 s (±0.02 s) |
0.98 |
| Startup Time - 2 cores | 0.75 s (±0.02 s) |
0.74 s (±0.02 s) |
1.02 |
| Startup Time - 4 cores | 0.75 s (±0.02 s) |
0.74 s (±0.02 s) |
1.01 |
| multithreaded_benchmark Build Time | 92.15 s |
82.11 s |
1.12 ❗ |
| multithreaded_benchmark File Size | 0.85 MB |
0.86 MB |
0.99 ❗ |
| Multithreaded Pi Efficiency - 2 Threads | 68.86 % (±6.84 %) |
85.89 % (±6.61 %) |
0.80 ❗ |
| Multithreaded Pi Efficiency - 4 Threads | 41.27 % (±3.19 %) |
43.43 % (±2.56 %) |
0.95 |
| Multithreaded Pi Efficiency - 8 Threads | 20.47 % (±2.26 %) |
25.76 % (±1.53 %) |
0.79 ❗ |
| micro_benchmarks Build Time | 230.67 s |
80.40 s |
2.87 ❗ |
| micro_benchmarks File Size | 0.85 MB |
0.86 MB |
0.99 ❗ |
| Scheduling time - 1 thread | 174.95 ticks (±29.16 ticks) |
62.65 ticks (±4.06 ticks) |
2.79 ❗ |
| Scheduling time - 2 threads | 104.43 ticks (±17.43 ticks) |
34.08 ticks (±4.10 ticks) |
3.06 ❗ |
| Micro - Time for syscall (getpid) | 11.67 ticks (±5.17 ticks) |
3.45 ticks (±0.58 ticks) |
3.38 ❗ |
| Memcpy speed - (built_in) block size 4096 | 57620.52 MByte/s (±40209.45 MByte/s) |
82448.38 MByte/s (±56997.13 MByte/s) |
0.70 |
| Memcpy speed - (built_in) block size 1048576 | 13035.39 MByte/s (±10702.55 MByte/s) |
30585.98 MByte/s (±24707.84 MByte/s) |
0.43 |
| Memcpy speed - (built_in) block size 16777216 | 8683.79 MByte/s (±7320.87 MByte/s) |
26340.06 MByte/s (±21720.96 MByte/s) |
0.33 |
| Memset speed - (built_in) block size 4096 | 57675.08 MByte/s (±40240.78 MByte/s) |
82292.76 MByte/s (±56891.50 MByte/s) |
0.70 |
| Memset speed - (built_in) block size 1048576 | 13288.17 MByte/s (±10842.44 MByte/s) |
31323.85 MByte/s (±25145.86 MByte/s) |
0.42 |
| Memset speed - (built_in) block size 16777216 | 8768.49 MByte/s (±7352.66 MByte/s) |
27104.68 MByte/s (±22209.94 MByte/s) |
0.32 |
| Memcpy speed - (rust) block size 4096 | 52630.28 MByte/s (±37945.91 MByte/s) |
74097.96 MByte/s (±51811.44 MByte/s) |
0.71 |
| Memcpy speed - (rust) block size 1048576 | 14597.29 MByte/s (±11963.08 MByte/s) |
30361.60 MByte/s (±24602.37 MByte/s) |
0.48 |
| Memcpy speed - (rust) block size 16777216 | 9126.75 MByte/s (±7795.73 MByte/s) |
27625.34 MByte/s (±22806.88 MByte/s) |
0.33 |
| Memset speed - (rust) block size 4096 | 53095.69 MByte/s (±38194.93 MByte/s) |
74373.47 MByte/s (±51976.48 MByte/s) |
0.71 |
| Memset speed - (rust) block size 1048576 | 14932.49 MByte/s (±12129.44 MByte/s) |
31110.89 MByte/s (±25033.24 MByte/s) |
0.48 |
| Memset speed - (rust) block size 16777216 | 9168.78 MByte/s (±7807.16 MByte/s) |
28386.93 MByte/s (±23265.03 MByte/s) |
0.32 |
| alloc_benchmarks Build Time | 227.75 s |
74.76 s |
3.05 ❗ |
| alloc_benchmarks File Size | 0.86 MB |
0.87 MB |
0.98 ❗ |
| Allocations - Allocation success | 91.38 % |
91.31 % |
1.00 ❗ |
| Allocations - Deallocation success | 100.00 % |
100.00 % |
1 |
| Allocations - Pre-fail Allocations | 61.60 % |
61.44 % |
1.00 ❗ |
| Allocations - Average Allocation time | 26526.86 Ticks (±1686.33 Ticks) |
5860.58 Ticks (±98.43 Ticks) |
4.53 ❗ |
| Allocations - Average Allocation time (no fail) | 27931.14 Ticks (±2119.52 Ticks) |
6554.81 Ticks (±92.86 Ticks) |
4.26 ❗ |
| Allocations - Average Deallocation time | 8635.95 Ticks (±1791.85 Ticks) |
1805.01 Ticks (±250.35 Ticks) |
4.78 ❗ |
| mutex_benchmark Build Time | 218.27 s |
79.82 s |
2.73 ❗ |
| mutex_benchmark File Size | 0.85 MB |
0.86 MB |
0.99 ❗ |
| Mutex Stress Test Average Time per Iteration - 1 Threads | 35.90 ns (±6.85 ns) |
12.10 ns (±0.41 ns) |
2.97 ❗ |
| Mutex Stress Test Average Time per Iteration - 2 Threads | 31.92 ns (±8.67 ns) |
40.26 ns (±1.68 ns) |
0.79 |
This comment was automatically generated by workflow using github-action-benchmark.
GloriousAlpaca
force-pushed
the
pr-keyboard-clean
branch
2 times, most recently
from
July 6, 2026 16:30
2c424d5 to
f6c859b
Compare
mkroening
previously requested changes
Jul 7, 2026
mkroening
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR! :)
I was wondering why implement drivers for legacy devices instead of USB keyboards (xhci, usb-oxide, embassy-usb). I guess it is because of simplicity.
It would be great to discuss the high-level application-facing API, since that is the hardest to change once merged.
GloriousAlpaca
force-pushed
the
pr-keyboard-clean
branch
3 times, most recently
from
July 17, 2026 14:24
a7180a7 to
153302f
Compare
jounathaen
reviewed
Jul 24, 2026
jounathaen
reviewed
Jul 24, 2026
jounathaen
reviewed
Jul 24, 2026
jounathaen
reviewed
Jul 24, 2026
jounathaen
reviewed
Jul 24, 2026
GloriousAlpaca
force-pushed
the
pr-keyboard-clean
branch
from
July 24, 2026 12:37
3473d4f to
2913b39
Compare
GloriousAlpaca
force-pushed
the
pr-keyboard-clean
branch
from
August 1, 2026 17:27
4e33054 to
166f396
Compare
GloriousAlpaca
force-pushed
the
pr-keyboard-clean
branch
4 times, most recently
from
August 11, 2026 13:53
452458e to
9afbade
Compare
jounathaen
reviewed
Aug 13, 2026
jounathaen
reviewed
Aug 13, 2026
jounathaen
reviewed
Aug 13, 2026
jounathaen
reviewed
Aug 13, 2026
jounathaen
reviewed
Aug 13, 2026
jounathaen
reviewed
Aug 13, 2026
jounathaen
reviewed
Aug 13, 2026
jounathaen
reviewed
Aug 13, 2026
jounathaen
reviewed
Aug 13, 2026
jounathaen
approved these changes
Aug 26, 2026
jounathaen
dismissed
mkroening’s stale review
August 26, 2026 12:26
All requested changes were implemented
GloriousAlpaca
force-pushed
the
pr-keyboard-clean
branch
from
August 26, 2026 12:31
3c3302d to
009e0fa
Compare
jounathaen
enabled auto-merge
August 26, 2026 12:31
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature adds support for the PS2 legacy keyboard in Qemu x86_64.
Currently it does:
The systemcall returns 0 if the keyboard feature is disabled.
I have only tested this feature with C programs on a Mac using Qemu.