fix(react): externalize react-aria subpaths to prevent vendored copy - #6653
Merged
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6651
📝 Description
The rollup
externallist only externalized the exactreact-ariastring (from dependencies) andreact-aria-componentssubpaths, but notreact-aria/*subpaths. As a result, subpath imports likereact-aria/useFocusable(Tooltip) andreact-aria/useCalendar(CalendarYearPicker) were bundled, andpreserveModulesvendored a full second copy of react-aria intodist/node_modules/.That duplicate copy created its own
FocusableContext, so in pnpm hoisted monorepos (where react-aria isn't deduped)Tooltip.Triggerconsumed a different context than thereact-aria-componentsprovider, leaving the trigger non-focusable and the tooltip never opening.Add
/^react-aria($|\/)/so all react-aria subpaths resolve against the consumer's single deduped copy. Both subpaths are public via react-aria's./*exports, so externalizing is safe and removes the vendoreddist/node_modulesentirely.⛳️ Current behavior (updates)
tooltip.jscalendar-year-picker.js🚀 New behavior
tooltip.jscalendar-year-picker.js💣 Is this a breaking change (Yes/No):
No
📝 Additional Information