fix(tooltip): preserve ButtonGroup context for tooltip-wrapped buttons - #6730
fix(tooltip): preserve ButtonGroup context for tooltip-wrapped buttons#6730wanxiankai wants to merge 4 commits into
Conversation
|
@wanxiankai is attempting to deploy a commit to the HeroUI Inc Team on Vercel. A member of the Team first needs to authorize it. |
wingkwong
left a comment
There was a problem hiding this comment.
please verify locally once first before making a PR. The changes failed all QA.
|
Thanks for checking. You're right — the first version leaked the internal ButtonGroup marker into the exported Tooltip type, which caused the QA TypeScript/build failures:
I pushed |
wingkwong
left a comment
There was a problem hiding this comment.
You may verify by running pnpm typecheck and pnpm build first.
Prevent BUTTON_GROUP_CHILD from leaking into generated declarations. Verified with pnpm typecheck and pnpm build.
|
Thanks — I reproduced the issue locally on 5fb754d. I pushed d24d501 to explicitly expose TooltipRoot as Local verification now passes:
The new QA workflow run 30183835766 completed with no jobs, so it still needs approval/re-run from a maintainer. |
commit: |
wingkwong
left a comment
There was a problem hiding this comment.
The scope is too narrow as you only cover Tooltip. Also it is a generic wrapper and should not know anything about Button or ButtonGroup internals. If the intent is "transparent wrappers forward unknown props to their first child", it should be implemented generically without importing Button.
Implement generic child prop forwarding for transparent trigger wrappers without coupling Tooltip to Button internals.
|
Thanks for the feedback. Updated in 2a8a7ec.
Verified with Could you please take another look? |
Summary
Verification
pnpm typecheck:reactpnpm lint:reactpnpm build