Skip to content

fix(proxy): stop emitting allowInsecure for domains with a valid cert #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yarrrly wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(proxy): stop emitting allowInsecure for domains with a valid cert #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions hiddifypanel/hutils/proxy/shared.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,16 +350,13 @@ def sni_host_server_extractor(domain_db: Domain, hconfigs):
server = str(random_or_none(hutils.network.get_domain_ips_cached(server)) or server)

allow_insecure = not domain_db.need_valid_ssl
if all_snis := split_pattern.split((domain_db.servernames or "").strip()):
if all_snis := [s for s in split_pattern.split((domain_db.servernames or "").strip()) if s]:
sni = random_or_none(all_snis) or sni
if domain_db.is_reality():
allow_insecure = False
if hconfigs[ConfigEnum.core_type] == "singbox": # TODO
sni = all_snis[0]

else:
allow_insecure = True

base = {
"sni": sni,
"host": host,
Expand Down
Loading