[hivecommons-hive]

Stops pack apply from seeding the pack model onto a kept hand-set backend that differs from the pack backend (e.g. codex). Adds table-driven test and changelog fragment.

Closes #13288

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[github-actions]

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

[hivecommons-hive]

hive/awaiting-ci: CI pending — sweep will merge when green.

---

🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Looks correct to me. Traced the interaction with the backend block that runs after this (src/pkg/dashboard/api_packs.go:278-292):

• existing.Backend == "" → onOtherBackend is false, model is seeded as before, then backend is filled with packBackend at :279. Unchanged behaviour.
• existing.Backend non-empty, allowed, ≠ pack backend (the #13288 case, e.g. codex) → backend is kept at :285 (fill-if-empty only), and the new guard at :212-214 now stops the pack's model id landing on it. This is the fix.
• existing.Backend non-empty but denied → :285-291 moves it to packBackend and clears a pack-owned model anyway; previously the model was seeded then cleared, now it is never seeded — same end state ("").

So the only observable change is the intended one. strings.EqualFold matches how agentOnForeignGatewayBackend (:1084) already compares backends. Test table covers kept-with-model, kept-without-model and pack-backend cases.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

hive/awaiting-ci: pushed 22d9f96 narrowing the #13288 guard to operator-owned backends (the two pre-existing pack-reconcile tests seed a pack-owned differing backend and expect the pack model). CI pending — sweep will merge when green.

---

🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 22d9f96

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Read the change against src/pkg/dashboard/api_packs.go at 22d9f96 and the callers around it. Looks correct to me.

• The new onOtherBackend guard (api_packs.go:214-215) only fires for an operator-owned backend that differs from packBackend; BackendIsOperatorOwned is BackendOwner == FieldOwnerOperator (src/pkg/config/config.go:2219), so a pack-owned backend that merely differs still takes the pack model, as the comment says.
• The backend reconciliation block further down (api_packs.go:~281-291) only fills empty or moves pack-owned denied backends, so the kept codex backend the issue describes survives the apply and now no longer receives claude-sonnet-4-6.
• Of the three table rows in TestApplyPackModelOnKeptOrReplacedBackend, "kept codex without model is not seeded" would have failed before this change (model would be seeded by the block at line 219), so the test is a real regression guard; the "pack backend is seeded" row confirms the existing behaviour from TestApplyPackSeedsModelOnPackBackend is unchanged.

Matches the scope of #13288 (Closes #13288); changelog fragment name follows fixed-<slug>.md.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Evidence bundle `#1333422d9f96` sha256:440bf95c8460ea0960c5471a9a6d9f82eabdca58576b560b9ded9512438b1861 — download from the dashboard or `hivectl review evidence #13334`.

[github-actions]

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback