Skip to content

fix: preserve storey height in zone conversion - #6

Closed
hongyuanjia wants to merge 1 commit into
mainfrom
fix/zone-storey-height
Closed

fix: preserve storey height in zone conversion#6
hongyuanjia wants to merge 1 commit into
mainfrom
fix/zone-storey-height

Conversation

@hongyuanjia

@hongyuanjia hongyuanjia commented Jun 24, 2026

Copy link
Copy Markdown
Owner

Summary

Closes #4

Changes

  • Select STOREY.HEIGHT when reading ROOM/STOREY data for Zone conversion.
  • Add a focused in-memory SQLite test for the narrow conversion logic.
  • Add a skip_on_cran() real DeST SQLite fixture test that verifies converted Zone Ceiling Height values match source storey heights.

Out of scope

  • No changes to surface, construction, or schedule conversion.

@hongyuanjia

Copy link
Copy Markdown
Owner Author

Superseded by #9, which includes this zone-height fix together with the full local devtools::check gate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve storey height when converting ROOM records to Zone objects

1 participant