feat: convert windows to fenestration surfaces - #7
Merged
Conversation
hongyuanjia
force-pushed
the
feat/window-fenestration-surfaces
branch
from
June 24, 2026 07:22
21666ff to
4d1cfa9
Compare
hongyuanjia
force-pushed
the
feat/window-fenestration-surfaces
branch
3 times, most recently
from
June 24, 2026 09:21
1463f7d to
c08110c
Compare
hongyuanjia
marked this pull request as ready for review
June 24, 2026 09:49
hongyuanjia
force-pushed
the
feat/window-fenestration-surfaces
branch
from
June 24, 2026 09:51
c08110c to
3d9f4b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3.
This PR is stacked on #9 so the window conversion can be reviewed against the check-clean conversion baseline. After #9 lands, this branch can be rebased back onto main.
Changes
Local checks run with DESTEP_TEST_FIXTURE_DIR pointing at the real fixture directory: focused conv-window/to_eplus tests passed, and devtools::check returned 0 errors, 0 warnings, and 1 environment note for future file timestamp verification.
Out of scope