Skip to content

feat: convert windows to fenestration surfaces - #7

Merged
hongyuanjia merged 1 commit into
mainfrom
feat/window-fenestration-surfaces
Jun 24, 2026
Merged

feat: convert windows to fenestration surfaces#7
hongyuanjia merged 1 commit into
mainfrom
feat/window-fenestration-surfaces

Conversation

@hongyuanjia

@hongyuanjia hongyuanjia commented Jun 24, 2026

Copy link
Copy Markdown
Owner

Summary

Closes #3.

This PR is stacked on #9 so the window conversion can be reviewed against the check-clean conversion baseline. After #9 lands, this branch can be rebased back onto main.

Changes

  • Implement WINDOW to FenestrationSurface:Detailed conversion.
  • Choose the room-side parent surface from MAIN_ENCLOSURE/SURFACE and keep vertex order aligned with parent wall side.
  • Include window conversion in the default to_eplus() path when WINDOW records exist.
  • Add the two-layer test shape: an in-memory SQLite test plus a skip_on_cran() real DeST SQLite fixture test.

Local checks run with DESTEP_TEST_FIXTURE_DIR pointing at the real fixture directory: focused conv-window/to_eplus tests passed, and devtools::check returned 0 errors, 0 warnings, and 1 environment note for future file timestamp verification.

Out of scope

  • Window shading and detailed DeST window-type optical mappings remain separate follow-up work.

@hongyuanjia
hongyuanjia force-pushed the feat/window-fenestration-surfaces branch from 21666ff to 4d1cfa9 Compare June 24, 2026 07:22
@hongyuanjia
hongyuanjia changed the base branch from main to fix/devtools-check June 24, 2026 07:22
@hongyuanjia
hongyuanjia force-pushed the feat/window-fenestration-surfaces branch 3 times, most recently from 1463f7d to c08110c Compare June 24, 2026 09:21
@hongyuanjia
hongyuanjia marked this pull request as ready for review June 24, 2026 09:49
@hongyuanjia
hongyuanjia force-pushed the feat/window-fenestration-surfaces branch from c08110c to 3d9f4b0 Compare June 24, 2026 09:51
@hongyuanjia
hongyuanjia changed the base branch from fix/devtools-check to main June 24, 2026 09:51
@hongyuanjia
hongyuanjia merged commit ab4bcf2 into main Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert DeST WINDOW records to EnergyPlus fenestration surfaces

1 participant