Skip to content

feat(client): $path - #4636

Merged
yusukebe merged 7 commits into
honojs:nextfrom
ShaMan123:feat/$path
Feb 19, 2026
Merged

feat(client): $path#4636
yusukebe merged 7 commits into
honojs:nextfrom
ShaMan123:feat/$path

Conversation

@ShaMan123

@ShaMan123 ShaMan123 commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

closes #4186

@ShaMan123 ShaMan123 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yusukebe should I add docs? If so please point out where

I don't have bun so I didn't run those command

Comment thread src/client/types.test.ts Outdated
Comment thread src/client/types.test.ts Outdated
@codecov

codecov Bot commented Jan 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.43%. Comparing base (f7d272a) to head (55ed455).
⚠️ Report is 18 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #4636   +/-   ##
=======================================
  Coverage   91.43%   91.43%           
=======================================
  Files         173      173           
  Lines       11373    11385   +12     
  Branches     3296     3302    +6     
=======================================
+ Hits        10399    10410   +11     
- Misses        973      974    +1     
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ShaMan123
ShaMan123 requested a review from yusukebe February 2, 2026 09:16
@yusukebe yusukebe added the v4.12 label Feb 2, 2026
@yusukebe yusukebe changed the title feat(): $path feat(client): $path Feb 2, 2026

@yusukebe yusukebe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe

Copy link
Copy Markdown
Member

Hey @ShaMan123 !

I added the code to support an edge case, but it looks good! Let's go with this. This change is a new feature; we’ll include it in the next minor version, v4.12.0. Maybe the date isn't too far away. Please wait a bit. Thank you for your contribution!

@ShaMan123

Copy link
Copy Markdown
Contributor Author

Thanks!

@yusukebe
yusukebe changed the base branch from main to next February 19, 2026 10:15
@yusukebe
yusukebe merged commit 9524923 into honojs:next Feb 19, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Relative Path in Hono Client

2 participants