Repository navigation
Commit 478ecbc
docs(ci): the acceptance concurrency group cancels pending runs; say so
The comment on the acceptance-suite concurrency group said "Queueing costs
wall-clock and nothing else." That is wrong. A concurrency group holds one
running run and one pending run; when another joins, the older pending run is
cancelled. cancel-in-progress: false protects only the running one.
So several pull requests pushed in a burst leave all but the newest with every
acceptance job CANCELLED -- not a failure, not coverage, and not blocking,
since acceptance is not a required check. It happened to three of four v3.0.2
PRs in one afternoon. Worse, a release gate that is pending rather than running
is cancelled by a PR joining behind it, and the builds and npm publish that
need it never run.
The same comment also cited "a single named test failing while a release ran
concurrently" as a second instance of the collision. That was the outpost
custom-domain test, and it was not a collision: the API returns a 500 after the
domain is already created, and the harness retry then gets a 409 for the
test's own hostname. The misdiagnosis had become evidence; it is now recorded
as a counterexample instead.
The review skill gains "a cancelled acceptance run is not a run either", with
how to re-run one at a time. The release checklist gains a gate: no acceptance
run in progress or queued before `gh release create`.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012XtSQ2kfpcRXXqweskgXkH1 parent 492bb68 commit 478ecbc
3 files changed
Lines changed: 57 additions & 7 deletions
File tree
- .agents/skills
- hookdeck-cli-release
- hookdeck-cli-review
- .github/workflows
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| 33 | + | |
33 | 34 | | |
34 | 35 | | |
35 | 36 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
69 | 104 | | |
70 | 105 | | |
71 | 106 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | | - | |
21 | | - | |
| 19 | + | |
| 20 | + | |
22 | 21 | | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
27 | 41 | | |
28 | 42 | | |
29 | 43 | | |
| |||
0 commit comments