Skip to content

Commit dcf4a7c

Browse files
leggetterclaude
andcommitted
docs: correct the tag count, and source the required-check list
Two review findings on the hookdeck-cli-review skill. The tag-registration section said all five hand-maintained lists agree "on 21 distinct tags". Four of them carry 20: telemetry is the twenty-first and is registered separately in the same files -- run_telemetry() in run_parallel.sh, the acceptance-telemetry job in acceptance.yml, and its own -tags=telemetry command in the README. Only the README's "Run all automated tests" string carries all 21 in one list. A reviewer following the section's own instruction would have opened run_parallel.sh, counted 20, and reported drift that is not there -- the same failure the manual-tag exception was added to prevent. The required-check list is the only claim in the file sourced from GitHub branch-protection settings rather than from the tree, so it can rot without a commit. It now carries the gh api query to re-read it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 2340843 commit dcf4a7c

1 file changed

Lines changed: 19 additions & 2 deletions

File tree

  • .agents/skills/hookdeck-cli-review

‎.agents/skills/hookdeck-cli-review/SKILL.md‎

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,15 @@ unit-test build-linux build-mac build-windows
3232
Acceptance is not in that list. A pull request with a **red or skipped**
3333
acceptance run is still mergeable, and the merge button will not tell you.
3434

35+
That list is the one claim here with no source in the tree — it lives in
36+
GitHub's branch-protection settings, so it can change without a commit and
37+
without this file noticing. Re-read it rather than trusting it:
38+
39+
```
40+
gh api repos/hookdeck/hookdeck-cli/branches/main/protection \
41+
--jq '.required_status_checks.contexts'
42+
```
43+
3544
**So read `gh pr checks` and flag a red or skipped acceptance run**, because
3645
nothing else in the process will. That is the single most useful thing this
3746
review does that the required checks do not.
@@ -104,8 +113,16 @@ script but not in CI, it never runs on a pull request. Left out of the "run all"
104113
command, the documented way to run everything quietly stops running everything —
105114
and that one is the worst of the five, because the command still exits 0.
106115

107-
All five agree today, on 21 distinct tags. Check all five whenever a diff adds
108-
one.
116+
All five agree today — but count before reporting drift, because **four of the
117+
five carry 20 tags, not 21.** `telemetry` is the twenty-first, and it is
118+
registered *separately* in each of those same files: `run_telemetry()` in
119+
`run_parallel.sh`, the `acceptance-telemetry` job in `acceptance.yml`, and its
120+
own `-tags=telemetry` command in the README. Only the "Run all automated tests"
121+
string carries all 21 in a single list.
122+
123+
So a slice list that reads 20 is correct, not stale. Check all five whenever a
124+
diff adds a tag — and if the new tag is a telemetry one, check those three
125+
separate sites instead.
109126

110127
One thing the README gets wrong, before you trust it on this: it attributes the
111128
matrix to `.github/workflows/test-acceptance.yml`. That file only declares the

0 commit comments

Comments
 (0)