Skip to content

Commit fe1969d

Browse files
leggetterclaude
andcommitted
test(acceptance): realign the slice lists the rebalance left behind
The slice rebalance in a9ecc05 changed .github/workflows/acceptance.yml and nothing else. The same tag sets are maintained by hand in five places, and four of them were left on the old distribution — run_parallel.sh, the three per-slice commands in README, and the Parallelisation bullets. The effect was worse than stale documentation. Anyone running the suite locally got the old slice 0, the twelve-tag one the rebalance existed to break up, so a local run reproduced neither CI's timing nor its grouping. The README comments say "same tags as CI job 0" while listing different tags. Also brings the documented timeout to 30m, which CI moved to in 19370be when slice 0 timed out at 720 seconds. Found by the review skill, which names these five sites precisely because they drift independently. All four now agree with CI, verified by comparing the sets rather than the strings. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent a495e4b commit fe1969d

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

‎test/acceptance/README.md‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -92,16 +92,16 @@ go test -tags="basic guest connection source destination gateway mcp listen proj
9292
Same commands as CI; use when debugging a subset or running in parallel:
9393
```bash
9494
# Slice 0 (same tags as CI job 0)
95-
ACCEPTANCE_SLICE=0 HOOKDECK_CLI_TELEMETRY_DISABLED=1 go test -tags="basic guest connection source mcp listen project_use connection_list connection_upsert connection_error_hints connection_oauth_aws connection_update" ./test/acceptance/... -v -timeout 12m
95+
ACCEPTANCE_SLICE=0 HOOKDECK_CLI_TELEMETRY_DISABLED=1 go test -tags="basic guest mcp project_use" ./test/acceptance/... -v -timeout 30m
9696

9797
# Slice 1 (same tags as CI job 1)
98-
ACCEPTANCE_SLICE=1 HOOKDECK_CLI_TELEMETRY_DISABLED=1 go test -tags="request event" ./test/acceptance/... -v -timeout 12m
98+
ACCEPTANCE_SLICE=1 HOOKDECK_CLI_TELEMETRY_DISABLED=1 go test -tags="request event connection connection_list connection_update connection_oauth_aws connection_error_hints" ./test/acceptance/... -v -timeout 30m
9999

100100
# Slice 3 (same tags as CI job 3) - requires HOOKDECK_CLI_OUTPOST_TESTING_API_KEY
101-
ACCEPTANCE_SLICE=3 HOOKDECK_CLI_TELEMETRY_DISABLED=1 go test -tags="outpost" ./test/acceptance/... -v -timeout 12m
101+
ACCEPTANCE_SLICE=3 HOOKDECK_CLI_TELEMETRY_DISABLED=1 go test -tags="outpost" ./test/acceptance/... -v -timeout 30m
102102

103103
# Slice 2 (same tags as CI job 2)
104-
ACCEPTANCE_SLICE=2 HOOKDECK_CLI_TELEMETRY_DISABLED=1 go test -tags="attempt metrics issue transformation destination gateway" ./test/acceptance/... -v -timeout 12m
104+
ACCEPTANCE_SLICE=2 HOOKDECK_CLI_TELEMETRY_DISABLED=1 go test -tags="attempt metrics issue transformation destination gateway listen source connection_upsert" ./test/acceptance/... -v -timeout 30m
105105

106106
# Telemetry (same as CI acceptance-telemetry: force telemetry on)
107107
ACCEPTANCE_SLICE=0 HOOKDECK_CLI_TELEMETRY_DISABLED=0 go test -tags=telemetry ./test/acceptance/... -v -timeout 12m
@@ -145,9 +145,9 @@ Note a direct push to a branch triggers a `pull_request` run for any PR it heads
145145

146146
Tests are partitioned by **feature build tags** so CI and local runs can execute three matrix slices in parallel (each slice uses its own Hookdeck project and config file).
147147

148-
- **Slice 0 features:** `basic`, `guest`, `connection`, `source`, `mcp`, `listen`, `project_use`, `connection_list`, `connection_upsert`, `connection_error_hints`, `connection_oauth_aws`, `connection_update`
149-
- **Slice 1 features:** `request`, `event`
150-
- **Slice 2 features:** `attempt`, `metrics`, `issue`, `transformation`, `destination`, `gateway`
148+
- **Slice 0 features:** `basic`, `guest`, `mcp`, `project_use`
149+
- **Slice 1 features:** `request`, `event`, `connection`, `connection_list`, `connection_update`, `connection_oauth_aws`, `connection_error_hints`
150+
- **Slice 2 features:** `attempt`, `metrics`, `issue`, `transformation`, `destination`, `gateway`, `listen`, `source`, `connection_upsert`
151151
- **Telemetry job:** `telemetry` only — separate CI job with telemetry **not** disabled (see [CI/CD](#cicd))
152152

153153
The CI workflow (`.github/workflows/test-acceptance.yml`) runs three matrix jobs plus `acceptance-telemetry`. Matrix jobs set `HOOKDECK_CLI_TELEMETRY_DISABLED=1`; the telemetry job does not. No test names or regexes are listed in YAML.

‎test/acceptance/run_parallel.sh‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@ SLICE2_LOG="$LOG_DIR/slice2.log"
3333
SLICE3_LOG="$LOG_DIR/slice3.log"
3434
TELEMETRY_LOG="$LOG_DIR/telemetry.log"
3535

36-
SLICE0_TAGS="basic guest connection source mcp listen project_use connection_list connection_upsert connection_error_hints connection_oauth_aws connection_update"
37-
SLICE1_TAGS="request event"
38-
SLICE2_TAGS="attempt metrics issue transformation destination gateway"
36+
SLICE0_TAGS="basic guest mcp project_use"
37+
SLICE1_TAGS="request event connection connection_list connection_update connection_oauth_aws connection_error_hints"
38+
SLICE2_TAGS="attempt metrics issue transformation destination gateway listen source connection_upsert"
3939
SLICE3_TAGS="outpost"
4040

4141
run_slice0() {

0 commit comments

Comments
 (0)