Skip to content

Add shouldInclude & shouldIncludeAll - #43

Open
declension wants to merge 2 commits into
hspec:mainfrom
declension:add-should-includes
Open

Add shouldInclude & shouldIncludeAll#43
declension wants to merge 2 commits into
hspec:mainfrom
declension:add-should-includes

Conversation

@declension

Copy link
Copy Markdown
  • Add a new shouldInclude (Add shouldInclude #38 / A few more expectations #35)
  • Also, a shouldIncludeAll which provides subset-like expectations (generalised to any Foldables), with helpful (hopefully) messaging about missing elements
  • Add some tests around these
  • Replicate a few unexported helper functions, rather than mess with the overall structure (can happily change this)
  • Update Hpack / Cabal

Closes #38

 * Add a new `shouldInclude` (hspec#38 / hspec#35)
 * Also, a more general `shouldIncludeAll` which tests provides subset-like expectations (generalised to any `Foldable`s), with helpful (hopefully) messaging about missing elements
 * Replicate a few unexported helper functions, rather than mess with the overall structure
 * Add some tests around these
 * Update Hpack / Cabal

Closes hspec#38
 * Add a new `shouldInclude` (hspec#38 / hspec#35)
 * Also, a more general `shouldIncludeAll` which provides subset-like expectations (generalised to any `Foldable`s), with helpful (hopefully) messaging about missing elements
 * Add some tests around these
 * Replicate a few unexported helper functions, rather than mess with the overall structure
 * Update Hpack / Cabal

Closes hspec#38
@declension declension mentioned this pull request Jun 10, 2021
@declension

Copy link
Copy Markdown
Author

@sol if this is a no-go for you I can do the plan B and create a hspec-extras (as per your comment in #35)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add shouldInclude

1 participant