From 11d28f9bd6e97705e4037c9c6c6f2203c81d59e8 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Thu, 8 Dec 2022 17:06:52 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- zeus/common/file_ops.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/zeus/common/file_ops.py b/zeus/common/file_ops.py index 88e29d7..9d3f92e 100644 --- a/zeus/common/file_ops.py +++ b/zeus/common/file_ops.py @@ -225,7 +225,26 @@ def _untar(cls, src, dst=None): if dst is None: dst = os.path.dirname(src) with tarfile.open(src, 'r:gz') as tar: - tar.extractall(path=dst) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=dst) @classmethod def exists(cls, path):