[yrodiere]

Description

GHInvitation declared its own private int id field which shadowed the private long id in GHObject. Jackson deserialized the API's id into the shadow field, but GHObject.getId() read the parent's field which was always 0.

Remove the shadowing field, switch accept()/decline() to use getId(), add the missing expired field, and expose getters for all fields that were previously inaccessible: invitee, inviter, permission, repository, expired.

• Fixes GHInvitation getId always returns 0 #1598
• https://docs.github.com/en/rest/collaborators/invitations

Before submitting a PR:

• Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
• Add JavaDocs and other comments explaining the behavior.
• When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
• Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
• Run mvn -D enable-ci clean install site "-Dsurefire.argLine=--add-opens java.base/java.net=ALL-UNNAMED" locally. If this command doesn't succeed, your change will not pass CI.
• Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

• Fill in the "Description" above with clear summary of the changes. This includes:
  • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
  • Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
• All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
• Enable "Allow edits from maintainers".

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.59%. Comparing base (619c857) to head (08ecf77).

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #2343      +/-   ##
============================================
+ Coverage     85.41%   85.59%   +0.18%     
- Complexity     2568     2579      +11     
============================================
  Files           242      242              
  Lines          7577     7582       +5     
  Branches        399      399              
============================================
+ Hits           6472     6490      +18     
+ Misses          869      856      -13     
  Partials        236      236              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[yrodiere]

I pushed another commit to cover accept()/decline(), which apparently weren't being tested before, since codecov was unhappy.