This repository was archived by the owner on Mar 21, 2026. It is now read-only.
Repository navigation
fix(num_devices): fix num_shard/num device auto compute when NVIDIA_VISIBLE_DEVICES == "all" or "void" - #3346
Merged
Merged
Conversation
…ISIBLE_DEVICES == "all" the computed num_shards was always 1 in this case, no matter what Signed-off-by: Raphael Glon <oOraph@users.noreply.github.com>
…di mode Signed-off-by: Raphael Glon <oOraph@users.noreply.github.com>
drbh
approved these changes
Dec 18, 2025
oOraph
changed the title
Member
|
nice fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If NVIDIA_VISIBLE_DEVICES == "all" then auto computed num shards was always 1
NVIDIA_VISIBLE_DEVICES == "void" is a new value coming from nvidia container runtime > 1.18