Repository navigation
fix: iterate then wait potential out of bounds panic - #2282
Merged
Merged
Conversation
Signed-off-by: Luc Georges <luc.sydney.georges@gmail.com>
McPatate
force-pushed
the
fix/iterate_then_wait
branch
from
August 4, 2026 13:38
2ba4fd6 to
3e44938
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
Author
|
@SBrandeis reviewed IRL :) |
SBrandeis
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing
IntoIteratoronEncodeHandlegives us the compile time guarantee that we consume the handle on iteration and cannot call.waiton it later on, which won't mess up the indexing of the result vec.This means the API is either iteration or waiting for all results.