Repository navigation
fix(bpe): the byte gate classifies the delimiter, not the word - #2294
Merged
Merged
Conversation
`merge_word` indexes `byte_to_mode` on `sequence.as_bytes()[0]`, but a
pre-tokenizer hands the model its delimiter attached to the front, so byte 0
describes the delimiter rather than the word. ByteLevel gives `"Ġword"`
(`Ġ` = U+0120 = `C4 A0`), Metaspace gives `"▁word"` (`▁` = U+2581 = `E2 96 81`)
— both land above 0x7F and take GATE_MULTI(8), even when the word behind them
is pure ASCII and belongs on GATE_ASCII(24).
`build_byte_to_gate` already special-cases a literal leading space down to
GATE_MULTI, with a comment noting that the first byte "says nothing about the
script of the rest" — so the hazard was known. The multibyte spellings of the
same delimiter never got the same treatment, and forcing them to MULTI is the
wrong direction anyway: the answer is to classify the content.
`content_start` skips one leading delimiter (`▁`, `Ġ`, or ASCII whitespace) and
`merge_word` indexes the gate there. A delimiter-only word keeps offset 0,
where MULTI remains the right conservative answer.
Reach, on 200 kB of the english corpus with the gpt2 pre-tokenizer: 30.6% of
words sit in the gate's decision band (9..24 bytes) AND are Ġ-prefixed with
ASCII content, so they change engine. On code.txt only 0.9% do.
Measured, gpt2/english, 10 kB chunks, best-of-3 warm, three interleaved A/B
rounds to cancel drift:
with fix 97.2 98.3 98.7 MB/s
without 89.4 91.0 85.3 MB/s
Non-overlapping: +10.7%. code/dense/russian/chinese are flat, consistent with
their much smaller affected fraction.
Byte-exact by construction — the gate only chooses between two merge engines
that must already agree — and confirmed: identical token counts on every
model/corpus probed. `cargo test -p tk-encode` 311/313, the one failure
(`normalizers::precompiled::pipeline_precompiled_matches_legacy`, a missing
data fixture) reproduces unchanged without this commit.
NOT a fix for llama-2. Its config has `pre_tokenizer: None`, so a 10 kB chunk
arrives as a single word whose length exceeds both gates; it always took the
two-tier queue and still does. llama-2's cost is the merge over one unbounded
span, which is a separate problem.
ArthurZucker
commented
Aug 5, 2026
SBrandeis
approved these changes
Aug 5, 2026
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
commented
Aug 5, 2026
ArthurZucker
added a commit
that referenced
this pull request
Aug 6, 2026
* wip / ai: scratch pool * scratch pool iteration * implement word cache * lint * change defaults + max length + capacity bump * more sensible values * rewrite without hashmap * iteration * iteration * fmt * review comments * draft first commit * nits * proper bpe only benches * proper features * update * update what we balckbox * comments * commetn * first drafts * fix glue * draft table builds * start mphf draft * impl get * fix mphf * nits * fixes * slowly but surely * fixes * table tests pass * create top merges * update * up * progress in the conversion table build * update * fixes * dman * ... * eager flag was missing * update * design a manual example * with / without thief * remove some shit * more simplifications * single test move it * draft engine * remove complication * remove one flag that was not worth it * current status * monomorphize for perfs * fixes * rename * start drafting the two tier merge * todo is getting fixed * nit * SparseFold for table! * move stuff around * multipass bpe * scratches * isolate pipeline bpe * remove unused mergemap * u16 is faster * add convert.rs * update * less branches * update * it was not worth it * finally * nits, renaming and moving files here and there * renaming * fix more of the renaming * pipeline vs legacy * first fix for the gate * update the local bench * up * bit better benches * update * revert unrelated changes * more reverts * more reversion! * cleanup * nits * more clippy * perf(merge bpe): improvement suggestions (#2275) * rewrite + document multipass * rename * perf: save a lookup when there is no merge * perf: compiler gotchas * Idiomacy: - Use a trait generic instead of a const generic - 2 Specialized struct instead of mangling all into SymbolSink - fn that had no reason to live in impl PipelineBpe are moved oout * review: address comments on merge_multipass - reword the copy/merge cursor step, drop the redundant invariant line - show the trailing dead slots in the pass diagrams instead of shrinking the boxes, with a legend for the padding - apply the suggested SAFE-bit wording - move MergeState above merge_once, its only user - has_merged -> was_merged, known_pair_value -> cached_pair_value - inline copy_last into merge_once - reframe the step doc around the lookup it wins back --------- Co-authored-by: Arthur <arthur.zucker@gmail.com> * fix(bpe): the byte gate classifies the delimiter, not the word (#2294) * fix(bpe): the byte gate classifies the delimiter, not the word `merge_word` indexes `byte_to_mode` on `sequence.as_bytes()[0]`, but a pre-tokenizer hands the model its delimiter attached to the front, so byte 0 describes the delimiter rather than the word. ByteLevel gives `"Ġword"` (`Ġ` = U+0120 = `C4 A0`), Metaspace gives `"▁word"` (`▁` = U+2581 = `E2 96 81`) — both land above 0x7F and take GATE_MULTI(8), even when the word behind them is pure ASCII and belongs on GATE_ASCII(24). `build_byte_to_gate` already special-cases a literal leading space down to GATE_MULTI, with a comment noting that the first byte "says nothing about the script of the rest" — so the hazard was known. The multibyte spellings of the same delimiter never got the same treatment, and forcing them to MULTI is the wrong direction anyway: the answer is to classify the content. `content_start` skips one leading delimiter (`▁`, `Ġ`, or ASCII whitespace) and `merge_word` indexes the gate there. A delimiter-only word keeps offset 0, where MULTI remains the right conservative answer. Reach, on 200 kB of the english corpus with the gpt2 pre-tokenizer: 30.6% of words sit in the gate's decision band (9..24 bytes) AND are Ġ-prefixed with ASCII content, so they change engine. On code.txt only 0.9% do. Measured, gpt2/english, 10 kB chunks, best-of-3 warm, three interleaved A/B rounds to cancel drift: with fix 97.2 98.3 98.7 MB/s without 89.4 91.0 85.3 MB/s Non-overlapping: +10.7%. code/dense/russian/chinese are flat, consistent with their much smaller affected fraction. Byte-exact by construction — the gate only chooses between two merge engines that must already agree — and confirmed: identical token counts on every model/corpus probed. `cargo test -p tk-encode` 311/313, the one failure (`normalizers::precompiled::pipeline_precompiled_matches_legacy`, a missing data fixture) reproduces unchanged without this commit. NOT a fix for llama-2. Its config has `pre_tokenizer: None`, so a 10 kB chunk arrives as a single word whose length exceeds both gates; it always took the two-tier queue and still does. llama-2's cost is the merge over one unbounded span, which is a separate problem. * Update tokenizers/tk-encode/src/models/bpe/merge_hot_cold_queue.rs * Update tokenizers/tk-encode/src/models/bpe/merge_hot_cold_queue.rs * Perf/bpe merge review (#2297) * chore(node): sync Cargo.lock with tk-encode's libc dependency * refactor(bpe): flatten the filename prefixes, group the released-crate BPE under legacy/ * refactor(bpe): split the tables file, document the packed merge value once * refactor(bpe): move code next to its users * refactor(bpe): one name per concept * refactor(bpe): collapse the three copies of the char-as-bytes push * perf(bpe): prove the whole-pretoken fold per entry instead of trusting the flag (onto #2241) (#2302) * perf(bpe): prove the whole-pretoken fold per entry instead of trusting the flag `ignore_merges` lets a pretoken that is itself a vocabulary entry be emitted as that entry, skipping the merge loop. It is declared in the config, so models trained expecting it (llama-3) get it and gpt2 does not -- even though ~93% of English pretokens are a single vocabulary entry that provably cannot encode to anything else. The property is checkable, so it need not be assumed. At load, run the merge engine on each entry's own text and record whether it reduces back to itself. Configs that already declare `ignore_merges` are untouched; the proof only runs when the config did not ask, so this can only enable a case that was safe. A bitset, not a bool. A single flag is all-or-nothing and one entry is enough to lose it: on gpt2 exactly one of 50,257 disagrees -- `<|endoftext|>`, which decomposes to seven tokens -- so a global flag reads "not provable" and the other 50,256 keep paying for it. Measured with a bool first: exactly flat. Per-entry bits cost 6.3 KB for gpt2 and a disagreeing entry costs only itself. Encoding is one probe into the vocabulary MPHF already held, then one bit test. No new table: the alternative for this workload is a large pretoken cache, and gigatoken's is ~64 MB against these 6.3 KB. Measured on the #2279 encode path (same change, ported here), gpt2, ns/byte, 10 kB documents each encoded once with the cache carried, median of 7 interleaved rounds: chat-mistral 4.01 -> 2.65 1.51x chat-chatml 3.88 -> 2.74 1.42x english 5.47 -> 4.01 1.36x math-latex 4.69 -> 3.97 1.18x code 3.11 -> 2.69 1.16x agentic-swe 3.16 -> 2.92 1.08x chinese 10.99 -> 10.89 1.01x hindi 2.61 -> 2.61 1.00x thai 5.48 -> 5.93 0.92x The gain tracks how often a pretoken is a whole vocabulary entry: 94.8% on chat-mistral and 93.1% on english against 37.6% on chinese and 11.9% on hindi. Thai loses 8% to probes that miss; gating the probe on the content-byte gate was tried and is a wash, because the miss path then computes the gate twice. Load cost is +7 ms median (61 -> 68 ms), the proof being one merge per entry. Exactness: the fold changes what the model emits, so it is the one thing that must be checked. Full benchmark matrix on the #2279 path, 7 models x 30 corpora: 174 cells byte-exact against tokenizers 0.23.1 and 29 mismatched -- the same 29 albert (Unigram) cells that already fail before this change. * perf(bpe): pack the foldable flag into the id, dropping the side bitset The proof's answer was kept in a separate 6.3 KB bitset consulted after the vocabulary probe. It does not need to exist: an id needs 31 bits at most, the lookup already loads the entry to verify the key, and this crate already packs flags beside an id -- a merge value is a product id in the low 30 bits with SAFE_MASK above it. Same convention here: FOLD_BIT is bit 31 of the stored id, VOCAB_ID_MASK is the rest. So the fold answer arrives on a load that already happened. No side table to allocate, no second structure to keep in step with the vocabulary, and no second lookup on the encode path. `get_bytes_foldable` returns both halves; `get_bytes` masks, so no caller sees the flag. `content`/`byte_content` mask too -- the bit must never escape this type, and an unmasked export would have leaked it into `get_vocab()`. Build asserts every id fits under the flag. The model keeps one `fold_by_flag` bool to tell "proven per entry" from "the config declared ignore_merges, so fold every hit". No behaviour change: 338 tests pass, including the test that pins ids for strings mixing folded words, merged words and a literal `<|endoftext|>`. * Apply suggestion from @ArthurZucker * docs(bpe): say where the hot queue's heap comes from hot_push/hot_pop are std's BinaryHeap sift_up/sift_down_range, vendored and specialised: min-order over a raw u64 key, so no Reverse wrapper around the packed (rank, index). Note the "hole" form too -- shift into the hole, write once -- since it reads like an unrolled swap otherwise. --------- Co-authored-by: SBrandeis <33657802+SBrandeis@users.noreply.github.com>
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on #2241 (
perf/bpe-merge).The bug
merge_wordpicks its merge engine from a table indexed by the word's first byte:But a pre-tokenizer hands the model its delimiter attached to the front, so byte 0 describes the delimiter, not the word. ByteLevel gives
"Ġword"(Ġ= U+0120 =C4 A0); Metaspace gives"▁word"(▁= U+2581 =E2 96 81). Both are ≥ 0x80, so both takeGATE_MULTI(8) — even when the word behind them is pure ASCII and belongs onGATE_ASCII(24).build_byte_to_gatealready special-cases a literal leading space down toGATE_MULTI, with a comment observing that the first byte "says nothing about the script of the rest". So the hazard was already known for" word"; the multibyte spellings of the same delimiter just never got the same treatment — and forcing them to MULTI is the wrong direction anyway. The fix is to classify the content.The change
content_startskips one leading delimiter (▁,Ġ, or ASCII whitespace) andmerge_wordindexes the gate there. A delimiter-only word (a run of spaces) keeps offset 0, where MULTI stays the right conservative answer.Reach
200 kB of
corpora/english.txtunder the gpt2 pre-tokenizer: 30.6% of words are both inside the gate's decision band (9..24 bytes) andĠ-prefixed with ASCII content, so they change engine. Oncode.txtonly 0.9% are.Measured
gpt2/english, 10 kB chunks, best-of-3 warm, three interleaved A/B rounds so machine drift cannot masquerade as the effect:
Non-overlapping ranges: +10.7%.
code,dense,russian,chineseare flat, consistent with their much smaller affected fraction.Byte-exactness
Guaranteed by construction — the gate only chooses between two merge engines that must already produce identical output — and confirmed empirically: identical token counts on every model × corpus probed (llama-2, gpt2, llama-3 × english/code/dense/russian/chinese).
cargo test -p tk-encode: 311 passed, 1 failed. The failure (normalizers::precompiled::tests::pipeline_precompiled_matches_legacy, a missing data fixture) reproduces unchanged with this commit stashed, so it is pre-existing.What this is not
Not a fix for llama-2. Its config has
pre_tokenizer: None, so a 10 kB chunk arrives as a single word whose length exceeds both gates — it always took the two-tier queue and still does. Measured: 31.4 vs 31.3 MB/s, i.e. unchanged. llama-2's cost is the merge over one unbounded span, and closing that needs a derived word split (e.g. proving from the vocab that no piece crosses a▁boundary, then splitting there), which is a separate change.