Skip to content

feat: encode_special_tokens flag - #2411

Merged
SBrandeis merged 6 commits into
feat/train_encode_splitfrom
feat/encode-specials-tag
Sep 18, 2026
Merged

SBrandeis merged 6 commits into
feat/train_encode_splitfrom
feat/encode-specials-tag

Conversation

@SBrandeis

Copy link
Copy Markdown
Collaborator

No description provided.

@SBrandeis
SBrandeis marked this pull request as ready for review September 16, 2026 10:29
@SBrandeis
SBrandeis requested review from ArthurZucker and McPatate and removed request for ArthurZucker September 17, 2026 21:58
Comment thread bindings/node/src/pipeline.rs Outdated
Comment on lines +26 to +27
/// Defaults to `false` when not set
pub encode_special_tokens: Option<bool>,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should default to true historically that's what people have been using.

@SBrandeis
SBrandeis force-pushed the feat/encode-specials-tag branch from 854c018 to 10e0d35 Compare September 18, 2026 10:27
@SBrandeis
SBrandeis merged commit 95f4b02 into feat/train_encode_split Sep 18, 2026
20 of 24 checks passed
@SBrandeis
SBrandeis deleted the feat/encode-specials-tag branch September 18, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants