Skip to content

Commit 76ca82a

Browse files
committed
Clean up changelog fragments and clarify the determinism mode comment
Drop two fragments left over from isaac-sim#7405, which merged: the docker and CLI changes they described are no longer part of this branch. Rename the isaaclab_newton fragment to describe the change that is actually here. The P-ADMM solver-combination fix now comes from develop, so the only remaining change in that package is the test update for Newton's new drive class names. State why the manipulation case asks for run_to_run rather than implying it matches the cartpole cases, which request the stronger gpu_to_gpu.
1 parent 92868b6 commit 76ca82a

5 files changed

Lines changed: 6 additions & 7 deletions

File tree

source/isaaclab/changelog.d/jichuanh-invariants-pull-on-deps-hit.skip

Lines changed: 0 additions & 1 deletion
This file was deleted.

source/isaaclab/changelog.d/jichuanh-kitless-isaac-sim-symlink.skip

Lines changed: 0 additions & 1 deletion
This file was deleted.
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
Test-only change: the actuator tests now assert Newton's new drive class names
2+
(``DrivePD``, ``DriveNeuralMLP``, ``DriveNeuralLSTM``). Newton 1.6.0rc1 still exports the
3+
old ``Controller*`` aliases, so there is no user-visible behavior change.

source/isaaclab_newton/changelog.d/jichuanh-newton-pin-4017-padmm-test.skip

Lines changed: 0 additions & 2 deletions
This file was deleted.

source/isaaclab_tasks/test/core/test_environment_determinism.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,9 @@ def setup_environment():
3939
("task_name", "deterministic_mode"),
4040
[
4141
# Newton defaults to ``wp.DeterministicMode.NOT_GUARANTEED``, under which Warp's atomics may
42-
# accumulate in any order, so two runs are not bit-reproducible. Ask for the guarantee this
43-
# test asserts, as the Newton cartpole cases below already do. ``deterministic_mode`` is a
44-
# Newton setting, so the PhysX-backed task leaves it unset.
42+
# accumulate in any order, so two runs are not bit-reproducible. ``run_to_run`` is exactly
43+
# the guarantee this test asserts: one device, one process, run twice. ``deterministic_mode``
44+
# is a Newton setting, so the PhysX-backed task leaves it unset.
4545
("Isaac-Open-Drawer-Franka", "run_to_run"),
4646
("IsaacContrib-Lift-Cube-Franka", None),
4747
],

0 commit comments

Comments
 (0)