refactor: CompositeTrackPicker control and some playback settings - #1063
Open
United600 wants to merge 3 commits into
Open
refactor: CompositeTrackPicker control and some playback settings#1063United600 wants to merge 3 commits into
United600 wants to merge 3 commits into
Conversation
Collaborator
Author
|
@huynhsontung If this direction works for you, despite my reservations about adding another singleton, I can move on to doing the same for |
fix subtitle and audio timing offsets bindings
United600
force-pushed
the
United600/flyout-composite-picker
branch
from
August 26, 2026 20:40
b0faf6b to
00f71cc
Compare
United600
marked this pull request as ready for review
August 26, 2026 20:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1057. Extracted playback-related settings into their own view model, refactored
AudioOptionsFlyoutandSubtitleOptionsFlyoutbinding logic, and moved the flyouts underCompositeTrackPicker.xamlfor better transition flow.Gravacao.2026-08-20.202529.mp4