fix(store): custom id for creating enumerable model (#298)

Author: smalluban

src/store.js

@@ -1311,7 +1311,7 @@ function set(model, values = {}) {
   if (!isDraft && values && hasOwnProperty.call(values, "id")) {
     if (!config.enumerable) {
       throw TypeError(`Values must not contain 'id' property: ${values.id}`);
-    } else if (!isInstance || values.id !== model.id) {
+    } else if (isInstance && values.id !== model.id) {
       throw TypeError(
         `You cannot change the 'id' property of the model instance: ${values.id}`,
       );

test/spec/store.js

@@ -383,10 +383,6 @@ describe("store:", () => {
       expect(() => store.set(Model, { id: "test" })).toThrow();
     });
 
-    it("throws an error when values contain 'id' property for enumerable model", async () => {
-      expect(() => store.set(Model, { id: "test" })).toThrow();
-    });
-
     it("throws an error when updating an instance and values contain different 'id' property", async () => {
       const model = await promise;
       expect(() => store.set(model, { ...model, id: "different" })).toThrow();
@@ -500,6 +496,14 @@ describe("store:", () => {
         expect(model.nestedArrayOfObjects[0].id).not.toBeDefined();
       }));
 
+    it('uses provided id for objects with "id" key', () =>
+      store
+        .set(Model, { id: 123, nestedArrayOfExternalObjects: [{ id: 456 }] })
+        .then((model) => {
+          expect(model.id).toBe("123");
+          expect(model.nestedArrayOfExternalObjects[0].id).toBe("456");
+        }));
+
     it("updates single property", () =>
       promise.then((model) =>
         store.set(model, { string: "new value" }).then((newModel) => {