fix: sort filter keys alphabetically

[knudtty]

Summary

Sorts keys in NestedFilterGroups alphabetically.

Screenshots or video

Before

After

References

• Linear Issue: Closes HDX-5754

[changeset-bot]

🦋 Changeset detected

Latest commit: 7c3e6d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@hyperdx/app	Patch
@hyperdx/api	Patch
@hyperdx/otel-collector	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
hyperdx-oss	Ready	Preview	Oct 16, 2026 8:47pm UTC
hyperdx-storybook	Ready	Preview	Oct 16, 2026 8:47pm UTC

[github-actions]

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

• Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats

• Production files changed: 2
• Production lines changed: 28 (+ 29 in test files, excluded from tier calculation)
• Branch: aaron/alphabetize-keys
• Author: knudtty

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

[github-actions]

PR Review

If you are a coding agent acting for the author, read this first.
Nothing below blocks merge automatically; a maintainer decides. What they will expect:

• 🔴 critical or 🟠 major in code this PR adds or changes: fix before asking for review.
• 🔵 minor in code this PR changes: your call. Fix if small, otherwise reply.
• Anything about surrounding code, or asking you to widen the change (hoist a helper,
  dedupe with another file, fix other call sites): never fix here, whatever the
  severity. Reply with one sentence; if it is critical, say so plainly so a human sees it.

One commit per review round. After two rounds, stop and ask a maintainer to review
scope rather than addressing more automated findings. Full rule: AGENTS.md.

3 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 3 minor

3 posted as inline comment(s) on the changed lines.

---

_{Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides.}

[github-actions]

Duplicate code analysis

No new duplicate code introduced by this PR.

---

jscpd compared this branch against origin/main
across app, api and common-utils. Only new clones are listed; the codebase
currently holds 125 in total (1.69%).
Run yarn dupes locally to reproduce, or yarn dupes:all for the full picture.

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new actionable issues remain.

Summary

Sorts nested filter keys alphabetically while keeping selected and pinned keys first.

• Nested filter keys in the search sidebar sort naturally within each group.

_{Reviews (5) · Last reviewed commit: "Update packages/app/src/components/DBSea..." · Reviewed by Greptile}

[github-actions]

Deep Review

✅ No critical issues found.

This is a small, well-scoped change: a new pure helper sortNestedFacetKeys that sorts keys within each nested Map/JSON filter group alphabetically, called in the shownFacets memo ahead of the existing priority sorts. The comparator was traced and is a valid total preorder (both-non-nested → 0, nested-vs-non-nested → non-nested first), the non-null assertions are safe because every nested baseName is populated before the comparator runs, and the ES2019 stable sort preserves within-group alphabetical order through the five subsequent equal-priority sorts. The prior Greptile comment (comment restating the code at the call site) was already addressed — the redundant comment was removed in 7c3e6d26.

🟡 P2 — recommended

• packages/app/src/components/DBSearchPageFilters/utils.test.ts:166 — the new behavior is covered by a single flat-array unit test; there is no test confirming within-group alphabetical order survives the five subsequent priority sorts (primary-key, pinned, shared-pinned, checked, range) that run on _facets after sortNestedFacetKeys.
  • Fix: add a test exercising a nested group where one child is checked or pinned, asserting that child surfaces first within its group while the remaining children stay alphabetical after all sorts.
  • _{correctness, testing}

🔵 P3 nitpicks (2)

• packages/app/src/components/DBSearchPageFilters/utils.ts:191 — parseMapFieldName is invoked twice per comparison inside facets.sort, i.e. O(n log n) regex/parse calls, plus once per element to build groupOrder.
  • Fix: precompute each facet's parsed {baseName, propertyPath} once into a map keyed by key and read from it inside the comparator.
• packages/app/src/components/DBSearchPageFilters/utils.ts:194 — the Number(!!nestedA) - Number(!!nestedB) branch that orders nested vs non-nested entries is terse and reads obliquely at the call site.
  • Fix: replace with an explicit nestedA ? 1 : -1-style expression or a short comment stating non-nested facets sort ahead of nested ones.

---

Reviewers (9): correctness, testing, maintainability, project-standards, kieran-typescript, performance, previous-comments, agent-native, learnings-researcher.

Testing gaps:

• No coverage for a nested group mixing checked/pinned and plain children (within-group order after priority sorts).
• No test for numeric-aware ordering within a group (e.g. item2 vs item10) to lock in Intl.Collator({numeric: true}) behavior beyond the single attr9/attr10 case.

_{No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond}

[github-actions]

E2E Test Results

✅ All tests passed • 431 passed • 1 skipped • 1457s

Status	Count
✅ Passed	431
❌ Failed	0
⚠️ Flaky	0
⏭️ Skipped	1

Tests ran across 4 shards in parallel.

View full report →

[github-actions]

🔵 minor — Nested groups in the Shared Filters section are still unsorted

sortNestedFacetKeys only runs inside shownFacets. sharedFacets (line 1296) is built in sharedFilterKeys insertion order and passed to the same renderFacetList (line 1779), so a team-pinned LogAttributes group lists its keys in pin order while the same group under Filters lists them A–Z. Call sortNestedFacetKeys on the sharedFacets result too, or do the sort inside renderFacetList before the priority ordering so both sections get it.

_{Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond}

[github-actions]

🔵 minor — Comparator re-parses both keys on every comparison

parseMapFieldName (which calls cleanClickHouseExpression, two regexes and parseKeyPath) runs twice per comparison, so about 2·n·log n times. shownFacets recomputes on every filterState change (every checkbox click), and hooks.ts:148 always includes every Map/JSON sub-field, so n can be large. Parse each key once, e.g. build a Map<key, parsed> in the first loop and read from it in the comparator.

_{Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond}

[github-actions]

🔵 minor — Test doesn't cover the ordering the changeset promises or toString()-wrapped JSON keys

The test only calls the helper on its own. The changeset says alphabetical keys come after keys with a selected value and pinned keys, which depends on the later stable sorts in DBSearchPageFilters.tsx:1373-1407. Nothing checks that, so moving the call below those sorts would still pass. JSON keys are also rewritten to toString(...) at line 1335, and the test has none. Add a case with toString(...) keys, and a component-level or extracted test showing that a checked or pinned child still sorts ahead of A–Z children in its group.

_{Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond}